From: Gregory Haskins <ghaskins@novell.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: RT <linux-rt-users@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
Gregory Haskins <ghaskins@novell.com>
Subject: [PATCH 8/9] RT: Fixes for push-rt patch
Date: Wed, 17 Oct 2007 14:51:08 -0400 [thread overview]
Message-ID: <20071017185108.11272.42107.stgit@novell1.haskins.net> (raw)
In-Reply-To: <20071017184745.11272.10024.stgit@novell1.haskins.net>
From: Steven Rostedt <rostedt@goodmis.org>
Steve found these errors in the original patch
Signed-off-by: Gregory Haskins <ghaskins@novell.com>
---
kernel/sched.c | 2 +-
kernel/sched_rt.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 0ee1e21..8c916de 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -1536,7 +1536,7 @@ static struct rq *find_lock_lowest_rq(struct task_struct *task,
for_each_cpu_mask(cpu, cpu_mask) {
struct rq *rq = &per_cpu(runqueues, cpu);
- if (cpu == smp_processor_id())
+ if (cpu == this_rq->cpu)
continue;
/* We look for lowest RT prio or non-rt CPU */
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c
index 8d59e62..04959fe 100644
--- a/kernel/sched_rt.c
+++ b/kernel/sched_rt.c
@@ -115,7 +115,7 @@ static struct task_struct *rt_next_highest_task(struct rq *rq)
queue = array->queue + idx;
next = list_entry(queue->next, struct task_struct, run_list);
- if (unlikely(next != current))
+ if (unlikely(next != rq->curr))
return next;
if (queue->next->next != queue) {
next prev parent reply other threads:[~2007-10-17 19:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 18:50 [PATCH 0/9] RT: RT-Overload/Sched enhancements v4 Gregory Haskins
2007-10-17 18:50 ` [PATCH 1/9] RT: push-rt Gregory Haskins
2007-10-17 18:50 ` [PATCH 2/9] RT: Add a per-cpu rt_overload indication Gregory Haskins
2007-10-17 18:50 ` [PATCH 3/9] RT: Wrap the RQ notion of priority to make it conditional Gregory Haskins
2007-10-17 18:50 ` [PATCH 4/9] RT: Initialize the priority value Gregory Haskins
2007-10-17 18:50 ` [PATCH 5/9] RT: Maintain the highest RQ priority Gregory Haskins
2007-10-17 18:50 ` [PATCH 6/9] RT: Clean up some of the push-rt logic Gregory Haskins
2007-10-17 18:51 ` [PATCH 7/9] RT: Add support for low-priority wake-up to push_rt feature Gregory Haskins
2007-10-17 18:51 ` Gregory Haskins [this message]
2007-10-17 18:51 ` [PATCH 9/9] RT: Only dirty a cacheline if the priority is actually changing Gregory Haskins
2007-10-20 2:48 ` Roel Kluin
2007-10-20 7:54 ` Steven Rostedt
2007-10-20 10:44 ` Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071017185108.11272.42107.stgit@novell1.haskins.net \
--to=ghaskins@novell.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®