From: Samuel Ortiz <sameo@openedhand.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Paul Sokolovsky <pmiscml@gmail.com>,
Ben Dooks <ben@trinity.fluff.org>
Subject: Re: [RFC] [PATCH -mm] ASIC3 driver
Date: Fri, 19 Oct 2007 01:42:28 +0200 [thread overview]
Message-ID: <20071018234227.GB19183@caravaggio> (raw)
In-Reply-To: <alpine.LFD.0.9999.0710190013420.22770@localhost.localdomain>
On Fri, Oct 19, 2007 at 12:15:47AM +0200, Thomas Gleixner wrote:
> On Thu, 18 Oct 2007, Andrew Morton wrote:
> > > +
> > > +#include <linux/module.h>
> > > +#include <linux/version.h>
> > > +#include <linux/irq.h>
> >
> > Please see the large comment at the top of linux/irq.h. I believe this
> > driver will fial to compile on at least arm.
> >
> > We really should fix this.
>
> drivers are fine with: #include <linux/interrupt.h>
>
> If they need linux/irq.h, then they do probably something really
> nasty.
The asic3 adds irqs to a board, through GPIOs. Is that a valid case ?
Cheers,
Samuel.
> tglx
next prev parent reply other threads:[~2007-10-19 0:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 9:12 Samuel Ortiz
2007-10-18 22:05 ` Andrew Morton
2007-10-18 22:15 ` Thomas Gleixner
2007-10-18 23:42 ` Samuel Ortiz [this message]
2007-10-19 10:53 ` Samuel Ortiz
2007-10-19 12:02 ` pHilipp Zabel
2007-10-19 18:00 ` Andrew Morton
2007-10-19 18:17 ` Thomas Gleixner
2007-10-20 11:31 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071018234227.GB19183@caravaggio \
--to=sameo@openedhand.com \
--cc=akpm@linux-foundation.org \
--cc=ben@trinity.fluff.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmiscml@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®