mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-pcmcia@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	Dominik Brodowski <linux@dominikbrodowski.net>
Subject: PCMCIA driver resource allocation
Date: Fri, 19 Oct 2007 10:51:51 -0600	[thread overview]
Message-ID: <200710191051.51686.bjorn.helgaas@hp.com> (raw)

Question 1: Does the linux-pcmcia list still exist?  It's in MAINTAINERS:

  PCMCIA SUBSYSTEM
  P:      Linux PCMCIA Team
  L:      linux-pcmcia@lists.infradead.org
  L:      http://lists.infradead.org/mailman/listinfo/linux-pcmcia
  T:      git kernel.org:/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git
  S:      Maintained

but the archive: http://lists.infradead.org/mailman/listinfo/linux-pcmcia
seems dead.

Question 2: Documentation/pcmcia/driver-changes.txt says drivers should
now claim their own resources:

  * Resource management. (as of 2.6.8)
     Although the PCMCIA subsystem will allocate resources for cards,
     it no longer marks these resources busy. This means that driver
     authors are now responsible for claiming your resources as per
     other drivers in Linux.

But I don't see any drivers that do that.  It looks like there should
be a bunch of changes like the one below.  Is there a reason these
changes didn't happen, other than just lack of interest?

Bjorn


Index: work3/drivers/net/wireless/orinoco.h
===================================================================
--- work3.orig/drivers/net/wireless/orinoco.h	2007-10-18 10:56:34.000000000 -0600
+++ work3/drivers/net/wireless/orinoco.h	2007-10-18 13:22:06.000000000 -0600
@@ -57,6 +57,7 @@
 	struct iw_statistics wstats;
 
 	/* Hardware control variables */
+	struct resource *io_resource;
 	hermes_t hw;
 	u16 txfid;
 
Index: work3/drivers/net/wireless/orinoco_cs.c
===================================================================
--- work3.orig/drivers/net/wireless/orinoco_cs.c	2007-10-18 10:56:34.000000000 -0600
+++ work3/drivers/net/wireless/orinoco_cs.c	2007-10-18 13:22:44.000000000 -0600
@@ -296,6 +296,10 @@
 	/* We initialize the hermes structure before completing PCMCIA
 	 * configuration just in case the interrupt handler gets
 	 * called. */
+	priv->io_resource = request_region(link->io.BasePort1,
+					   link->io.NumPorts1, DRIVER_NAME);
+	if (!priv->io_resource)
+		goto cs_failed;
 	mem = ioport_map(link->io.BasePort1, link->io.NumPorts1);
 	if (!mem)
 		goto cs_failed;
@@ -366,6 +370,10 @@
 	pcmcia_disable_device(link);
 	if (priv->hw.iobase)
 		ioport_unmap(priv->hw.iobase);
+	if (priv->io_resource) {
+		release_resource(priv->io_resource);
+		priv->io_resource = NULL;
+	}
 }				/* orinoco_cs_release */
 
 static int orinoco_cs_suspend(struct pcmcia_device *link)

             reply	other threads:[~2007-10-19 16:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 16:51 Bjorn Helgaas [this message]
2007-10-19 22:40 ` Russell King
2007-10-21 17:46   ` Kristoffer Ericson
2007-10-21  8:41     ` Russell King
2007-10-22 15:27   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710191051.51686.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmcia@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®