Re: [PATCH] Blackfin I2C/TWI driver: update for 2.6.24 merge windows

[Jean Delvare <khali@linux-fr.org>]

Hi Bryan,

On Thu, 18 Oct 2007 14:11:35 +0800, Bryan Wu wrote:
> Could you kindly review this patch?

I'm pretty busy these days, I don't have much spare time for reviews.

BTW, as a rule of thumb, I am ignoring patches that are sent to the
LKML in addition to the i2c list. If you think that your patch is so
important that it has to be send to a list with over 4500 subscribers
that sees 120.000 messages each year, then who am I to dare to comment
on it?

If you want me to consider your patches as something that needs my
attention, send them to the i2c list only, do not add LKML. This is
general advice for everyone sending i2c patches, not just you, of
course.

Back to your patch... Originally you posted two patches, and I see that
they are now merged into a single patch, why? It's much better to have
separate patches, it makes reviews and testing way easier. If you
provide separate patches I'll try to find some time to review them.

Note that this won't be for 2.6.24 anyway, it's too late for that, I've
already sent my i2c patches to Linus. From now on, only bugfixes can go
in 2.6.24, improvements will have to wait for 2.6.25.

-- 
Jean Delvare