From: Andrew Morton <akpm@linux-foundation.org>
To: dougthompson@xmission.com
Cc: dougthompson@xmission.com, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] drivers-edac-i3000 replace macros with functions
Date: Fri, 19 Oct 2007 14:11:18 -0700 [thread overview]
Message-ID: <20071019141118.91846dee.akpm@linux-foundation.org> (raw)
In-Reply-To: <471902ff.FaxIbGYEsl+dBZCd%dougthompson@xmission.com>
On Fri, 19 Oct 2007 13:18:23 -0600
dougthompson@xmission.com wrote:
> +static inline unsigned long deap_pfn(u8 edeap, u32 deap)
> +{
> + deap >>= PAGE_SHIFT;
> + deap |= (edeap & 1) << (32 - PAGE_SHIFT);
> + return deap;
> +}
> +
> +static inline unsigned long deap_offset(u32 deap)
> +{
> + return deap & ~(I3000_DEAP_GRAIN - 1) & ~PAGE_MASK;
> +}
> +
The types here look a bit confused. Implicit conversions of
u32s into unsigned longs.
next prev parent reply other threads:[~2007-10-19 21:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 19:18 dougthompson
2007-10-19 21:11 ` Andrew Morton [this message]
2007-10-19 23:58 ` Doug Thompson
2007-10-20 0:13 ` Jason Uhlenkott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071019141118.91846dee.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dougthompson@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®