Re: [PATCH] xconfig: set title bar

[Sam Ravnborg <sam@ravnborg.org>]

On Sat, Oct 20, 2007 at 11:18:47AM -0700, Randy Dunlap wrote:
> On Sat, 20 Oct 2007 19:14:03 +0200 Sam Ravnborg wrote:
> 
> > I found this one to work:
> > +       setCaption("hello my little world");
> 
> Thanks, your search expressions were better than mine.
> 
> > We should show the prompt associated with mainmenu here.
> 
> You want all 3 of them converted to
> 	symbol_value(mainmenu) + $KERNELVERSION

Well - if mainmenu should serve any purpose then yes.


> ?
> 
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Put kernel version info on title bar in xconfig (qconf) instead of
> defaulting to "qconf".
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  scripts/kconfig/qconf.cc |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> --- linux-2.6.23-git13.orig/scripts/kconfig/qconf.cc
> +++ linux-2.6.23-git13/scripts/kconfig/qconf.cc
> @@ -1274,8 +1274,12 @@ ConfigMainWindow::ConfigMainWindow(void)
>  	QMenuBar* menu;
>  	bool ok;
>  	int x, y, width, height;
> +	char title[256];
>  
>  	QWidget *d = configApp->desktop();
> +	sprintf(title, _("Linux Kernel v%s Configuration"),

I made this look like this:
> +	snprintf(title, sizeof(title), _("Linux Kernel v%s Configuration"),

because we may append to the KERNELVERSION using EXTRAVERSION and people could go insane.

	Sam