mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 6/17] drivers/char/riscom8: irq handler cleanups
Date: Sun, 21 Oct 2007 03:52:25 -0400 (EDT)	[thread overview]
Message-ID: <20071021075225.A1F9819041C@havoc.gtf.org> (raw)
In-Reply-To: <lkjvxcz09835mnsdfv0983q4m1234m@havoc.gtf.org>

commit 93ea6d56f83b7b614c103222fa098cb30d26f608
Author: Jeff Garzik <jeff@garzik.org>
Date:   Fri Oct 19 16:41:23 2007 -0400

    drivers/char/riscom8: irq handler cleanups
    
    No need to lookup board ptr, we already have it.
    
    Also, remove a few 'inline' markers and let the compiler make that
    decision.
    
    Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

 drivers/char/riscom8.c |   12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

93ea6d56f83b7b614c103222fa098cb30d26f608
diff --git a/drivers/char/riscom8.c b/drivers/char/riscom8.c
index b37e626..d307320 100644
--- a/drivers/char/riscom8.c
+++ b/drivers/char/riscom8.c
@@ -537,16 +537,14 @@ static inline void rc_check_modem(struct riscom_board const * bp)
 }
 
 /* The main interrupt processing routine */
-static irqreturn_t rc_interrupt(int irq, void * dev_id)
+static irqreturn_t rc_interrupt(int dummy, void * dev_id)
 {
 	unsigned char status;
 	unsigned char ack;
-	struct riscom_board *bp;
+	struct riscom_board *bp = dev_id;
 	unsigned long loop = 0;
 	int handled = 0;
 
-	bp = IRQ_to_board[irq];
-
 	if (!(bp->flags & RC_BOARD_ACTIVE))
 		return IRQ_NONE;
 
@@ -603,7 +601,7 @@ static irqreturn_t rc_interrupt(int irq, void * dev_id)
  */
 
 /* Called with disabled interrupts */
-static inline int rc_setup_board(struct riscom_board * bp)
+static int rc_setup_board(struct riscom_board * bp)
 {
 	int error;
 
@@ -611,7 +609,7 @@ static inline int rc_setup_board(struct riscom_board * bp)
 		return 0;
 	
 	error = request_irq(bp->irq, rc_interrupt, IRQF_DISABLED,
-			    "RISCom/8", NULL);
+			    "RISCom/8", bp);
 	if (error) 
 		return error;
 	
@@ -626,7 +624,7 @@ static inline int rc_setup_board(struct riscom_board * bp)
 }
 
 /* Called with disabled interrupts */
-static inline void rc_shutdown_board(struct riscom_board *bp)
+static void rc_shutdown_board(struct riscom_board *bp)
 {
 	if (!(bp->flags & RC_BOARD_ACTIVE))
 		return;

  parent reply	other threads:[~2007-10-21  7:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-21  7:52 [PATCH 0/17] various " Jeff Garzik
2007-10-21  7:52 ` [PATCH 1/17] " Jeff Garzik
2007-10-21  7:52 ` [PATCH 2/17] drivers/char/ip2: split out irq core logic into separate function Jeff Garzik
2007-10-21  7:52 ` [PATCH 3/17] drivers/char/ip2: separate polling and irq-driven work entry points Jeff Garzik
2007-10-21  7:52 ` [PATCH 4/17] char/pcmcia/synclink_cs: trim trailing whitespace Jeff Garzik
2007-10-21  7:52 ` [PATCH 5/17] drivers/char/pcmcia/synclink_cs.c: irq handler cleanups Jeff Garzik
2007-10-21  7:52 ` Jeff Garzik [this message]
2007-10-21  9:01   ` [PATCH 6/17] drivers/char/riscom8: " Jiri Slaby
2007-10-21  9:06     ` Jeff Garzik
2007-10-21  7:52 ` [PATCH 7/17] drivers/char/{rio,specialix,sx}: " Jeff Garzik
2007-10-21  7:52 ` [PATCH 8/17] arch/x86/kernel/vm86_32.c: irq handler cleanup Jeff Garzik
2007-10-21  9:21   ` Thomas Gleixner
2007-10-21  7:52 ` [PATCH 9/17] drivers/char/{synclink,tpm}: irq handler cleanups Jeff Garzik
2007-10-21  7:52 ` [PATCH 10/17] drivers/input/serio/i8042.c: irq handler clean Jeff Garzik
2007-10-21 17:57   ` Dmitry Torokhov
2007-10-30 12:36     ` Jeff Garzik
2007-10-21  7:52 ` [PATCH 11/17] isdn/act2000: fix major bug. clean irq handler Jeff Garzik
2007-10-21  7:52 ` [PATCH 12/17] isdn/sc: irq handler clean Jeff Garzik
2007-10-21  7:52 ` [PATCH 13/17] netdrvr irq handler cleanups Jeff Garzik
2007-10-21  7:52 ` [PATCH 14/17] pcmcia/i82365: " Jeff Garzik
2007-10-21  7:52 ` [PATCH 15/17] serial, rtc/ds1374: " Jeff Garzik
2007-10-21  7:52 ` [PATCH 16/17] SCSI: driver " Jeff Garzik
2007-10-21  7:52 ` [PATCH 17/17] RTC interrupt handling cleanups Jeff Garzik
2007-10-21 16:40   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071021075225.A1F9819041C@havoc.gtf.org \
    --to=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®