mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Linux Kernel Development" <linux-kernel@vger.kernel.org>,
	"Christian Bjølevik" <nafallo@magicalforest.se>,
	"Deepak Saxena" <dsaxena@mvista.com>,
	"Armin Kuster" <akuster@mvista.com>,
	"Adrian Bunk" <bunk@kernel.org>
Subject: Re: kbuild: disable depmod in cross-compile kernel build
Date: Mon, 22 Oct 2007 11:49:17 +0200	[thread overview]
Message-ID: <20071022094917.GA12064@uranus.ravnborg.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710211948450.6155@anakin>

> 
> Euh, is these really necessary?
> 
> At work I have no problems running depmod on an i386 system for ppc64 modules
> after I installed module-init-tools 3.3-pre2 (from Debian).
> I did have problems (depmod SEGV) using the depmod that came with CentOS
> 4 (from module-init-tools 3.1-pre5).

The patch was solely done due to people complaining and I even had a bugzilla
entry about it.
I expext Armin or Christian to speak up if this is a real problem for them.

PS. I did not do a revert since the original patch contained a nice cleanup.

	Sam

I have just committed the following:

>From d2c83557493c8595e2d3f31d0469bcf43d19b560 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@neptun.(none)>
Date: Mon, 22 Oct 2007 11:30:45 +0200
Subject: [PATCH] kbuild: allow depmod in cross builds again

depmod from module-init-tools 3.3-pre2 are reported
to work fine in cross build.
depmod from module-init-tools 3.1-pre5 are know to SEGV

Do not workaround older module-init-tools bug here.
The right fix is for users to upgrade module-init-tools.

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index f4238b2..264f37b 100644
--- a/Makefile
+++ b/Makefile
@@ -1505,7 +1505,7 @@ quiet_cmd_rmfiles = $(if $(wildcard $(rm-files)),CLEAN   $(wildcard $(rm-files))
 # and we build for the host arch
 quiet_cmd_depmod = DEPMOD  $(KERNELRELEASE)
       cmd_depmod = \
-	if [ -r System.map -a -x $(DEPMOD) -a "$(SUBARCH)" = "$(ARCH)" ]; then \
+	if [ -r System.map -a -x $(DEPMOD) ]; then                              \
 		$(DEPMOD) -ae -F System.map                                     \
 		$(if $(strip $(INSTALL_MOD_PATH)), -b $(INSTALL_MOD_PATH) -r)   \
 		$(KERNELRELEASE);                                               \
-- 
1.5.3.4.1157.g0e74-dirty


      parent reply	other threads:[~2007-10-22  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200710192259.l9JMxENl018922@hera.kernel.org>
2007-10-21 17:53 ` Geert Uytterhoeven
2007-10-21 18:18   ` Frans Pop
2007-10-22  9:49   ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071022094917.GA12064@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akuster@mvista.com \
    --cc=bunk@kernel.org \
    --cc=dsaxena@mvista.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nafallo@magicalforest.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome