From: David Miller <davem@davemloft.net>
To: jeff@garzik.org
Cc: netdev@vger.kernel.org, davej@redhat.com,
auke-jan.h.kok@intel.com, ajax@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e1000, e1000e valid-addr fixes
Date: Tue, 23 Oct 2007 19:23:13 -0700 (PDT) [thread overview]
Message-ID: <20071023.192313.115635750.davem@davemloft.net> (raw)
In-Reply-To: <471EABEE.8030900@garzik.org>
From: Jeff Garzik <jeff@garzik.org>
Date: Tue, 23 Oct 2007 22:20:30 -0400
> David Miller wrote:
> > From: Jeff Garzik <jeff@garzik.org>
> > Date: Tue, 23 Oct 2007 21:03:36 -0400
> >
> >> I'm wondering if there is a way to avoid adding
> >>
> >> if (!is_valid_ether_addr(dev->dev_addr))
> >> return -EINVAL;
> >>
> >> to every ethernet driver's ->open() hook.
> >
> > The first idea I get is:
> >
> > 1) Create netdev->validate_dev_addr().
> >
> > 2) If it exists, invoke it before ->open(), abort
> > and return if any errors signaled.
> >
> > etherdev init hooks up a function that does the above
> > check, which allows us to avoid editing every ethernet
> > driver
> >
> > What do you think?
>
> Seems sane to me. Something like this (attached)?
Looks great:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2007-10-24 2:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 14:58 [PATCH] Add eeprom_bad_csum_allow module option to e1000 Adam Jackson
2007-10-23 16:18 ` Kok, Auke
2007-10-23 16:21 ` Adam Jackson
2007-10-23 17:09 ` Kok, Auke
2007-10-23 20:40 ` Jeff Garzik
2007-10-23 21:01 ` Kok, Auke
2007-10-23 21:51 ` David Miller
2007-10-23 21:20 ` Dave Jones
2007-10-23 21:38 ` Alan Cox
2007-10-23 21:53 ` David Miller
2007-10-23 23:19 ` Kok, Auke
2007-10-24 0:55 ` [PATCH] e1000, e1000e valid-addr fixes Jeff Garzik
2007-10-24 1:03 ` Jeff Garzik
2007-10-24 1:07 ` David Miller
2007-10-24 2:20 ` Jeff Garzik
2007-10-24 2:23 ` David Miller [this message]
2007-11-01 18:04 ` Kok, Auke
2007-11-01 18:47 ` Jeff Garzik
2007-11-01 18:11 ` Stephen Hemminger
2007-11-01 19:31 ` Jeff Garzik
2007-10-24 1:15 ` Adrian Bunk
2007-10-23 23:03 ` [PATCH] Add eeprom_bad_csum_allow module option to e1000 Kok, Auke
2007-10-23 23:53 ` Stephen Hemminger
2007-10-24 5:38 ` Dave Jones
2007-10-23 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023.192313.115635750.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajax@redhat.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davej@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®