From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Anas Nashif <nashif@linux.intel.com>,
linux-kernel@vger.kernel.org, Marek Dabek <marek.dabek@intel.com>
Subject: Re: [PATCH] Intel Manageability Engine Interface driver
Date: Tue, 23 Oct 2007 14:05:48 -0400 [thread overview]
Message-ID: <20071023180547.GL4003@csclub.uwaterloo.ca> (raw)
In-Reply-To: <20071023092333.39982483@laptopd505.fenrus.org>
On Tue, Oct 23, 2007 at 09:23:33AM -0700, Arjan van de Ven wrote:
> gcc will tell you in the other direction just as well.
>
> and people read from left to right (at least in english) so coding in
> that direction is generally preferred in the Linux kernel as well.
What does gcc have to say about if (foo = 0){ rather than if (foo == 0){
Both are legal C so it shouldn't say anything. Of course the first is
usually a bug (or very bad style).
On the other hand if (0 = foo) will give an error.
It isn't about how you read in english, it is about not making mistakes.
And why can't you say if 0 is equal to the variable foo rather than if
the variable foo is equal to 0? Both are valid english, so that is just
a crappy excuse for sticking with a bad idea.
--
Len Sorensen
next prev parent reply other threads:[~2007-10-23 18:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 17:22 Anas Nashif
2007-10-22 18:28 ` Xavier Bestel
2007-10-22 18:40 ` Andrew Morton
2007-10-23 13:31 ` Anas Nashif
2007-10-23 13:36 ` Maxim Levitsky
2007-10-23 16:25 ` Andrew Morton
2007-10-23 15:04 ` Lennart Sorensen
2007-10-23 16:23 ` Arjan van de Ven
2007-10-23 18:05 ` Lennart Sorensen [this message]
2007-10-23 18:22 ` Roland Dreier
2007-10-23 19:35 ` Lennart Sorensen
2007-10-24 9:00 ` Bernd Petrovitsch
2007-10-23 16:32 ` Andrew Morton
2007-10-22 22:30 ` Maxim Levitsky
2007-10-23 13:35 ` Anas Nashif
2007-10-23 13:42 ` Maxim Levitsky
2007-10-25 9:33 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023180547.GL4003@csclub.uwaterloo.ca \
--to=lsorense@csclub.uwaterloo.ca \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.dabek@intel.com \
--cc=nashif@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®