From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: David Miller <davem@davemloft.net>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: Fix IDE host_flags regression.
Date: Tue, 23 Oct 2007 22:45:24 +0100 [thread overview]
Message-ID: <20071023224524.27d3acc0@the-village.bc.nu> (raw)
In-Reply-To: <200710232150.14284.bzolnier@gmail.com>
> - IDE_HFLAG_ERROR_STOPS_FIFO (the error path of pdc202xx_{old,new})
I've been playing with this a bit in libata - it seems the pdc202xx is a
bit more complicated. An error doesn't stop the FIFO, a reset does.
The problem thus seems to be triggered ultimately by the fact we call the
timeout method before doing a FIFO drain in some cases, and also that old
IDE tries to use PIO to flush a DRQ when the failing taskfile is a DMA
operation not PIO..
Alan
prev parent reply other threads:[~2007-10-23 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 9:09 David Miller
2007-10-23 19:50 ` Bartlomiej Zolnierkiewicz
2007-10-23 21:45 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023224524.27d3acc0@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®