From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756662AbXJXF3R (ORCPT ); Wed, 24 Oct 2007 01:29:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754049AbXJXF3F (ORCPT ); Wed, 24 Oct 2007 01:29:05 -0400 Received: from mtagate7.de.ibm.com ([195.212.29.156]:13109 "EHLO mtagate7.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753956AbXJXF3C (ORCPT ); Wed, 24 Oct 2007 01:29:02 -0400 Date: Wed, 24 Oct 2007 07:29:00 +0200 From: Heiko Carstens To: Jens Axboe Cc: Christoph Schmitt , Swen Schillig , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org Subject: [PATCH] sg: add missing sg_init_table calls to zfcp Message-ID: <20071024052900.GB12335@osiris.boeblingen.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org From: Heiko Carstens CONFIG_DEBUG_SG reveals two missing sg_init_table calls. Add them. kernel BUG at include/linux/scatterlist.h:50! illegal operation: 0001 [#1] [...] Call Trace: ([<000000000026f184>] zfcp_ns_gid_pn_request+0x4c/0x2a0) [<0000000000276dd4>] zfcp_erp_strategy_do_action+0x1410/0x1938 [<0000000000278412>] zfcp_erp_thread+0x4fa/0x1430 [<000000000001990a>] kernel_thread_starter+0x6/0xc [<0000000000019904>] kernel_thread_starter+0x0/0xc Cc: Swen Schillig Cc: Christof Schmitt Signed-off-by: Heiko Carstens --- Jens, could you please push this one via your tree? Thanks! drivers/s390/scsi/zfcp_aux.c | 2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6/drivers/s390/scsi/zfcp_aux.c =================================================================== --- linux-2.6.orig/drivers/s390/scsi/zfcp_aux.c +++ linux-2.6/drivers/s390/scsi/zfcp_aux.c @@ -1518,6 +1518,8 @@ zfcp_gid_pn_buffers_alloc(struct zfcp_gi return -ENOMEM; memset(data, 0, sizeof(*data)); + sg_init_table(&data->req , 1); + sg_init_table(&data->resp , 1); data->ct.req = &data->req; data->ct.resp = &data->resp; data->ct.req_count = data->ct.resp_count = 1;