From: Miklos Szeredi <miklos@szeredi.hu>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [patch 1/5] fuse: fuse_file_alloc(): fix NULL dereferences
Date: Wed, 24 Oct 2007 13:13:34 +0200 [thread overview]
Message-ID: <20071024111425.536479203@szeredi.hu> (raw)
In-Reply-To: <20071024111333.530227696@szeredi.hu>
[-- Attachment #1: fuse_file_alloc_fix.patch --]
[-- Type: text/plain, Size: 731 bytes --]
From: Adrian Bunk <bunk@kernel.org>
This patch fixes obvious NULL dereferences spotted by the Coverity
checker.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
---
Index: linux/fs/fuse/file.c
===================================================================
--- linux.orig/fs/fuse/file.c 2007-10-19 16:45:09.000000000 +0200
+++ linux/fs/fuse/file.c 2007-10-19 16:45:22.000000000 +0200
@@ -55,9 +55,10 @@ struct fuse_file *fuse_file_alloc(void)
if (!ff->reserved_req) {
kfree(ff);
ff = NULL;
+ } else {
+ INIT_LIST_HEAD(&ff->write_entry);
+ atomic_set(&ff->count, 0);
}
- INIT_LIST_HEAD(&ff->write_entry);
- atomic_set(&ff->count, 0);
}
return ff;
}
--
next prev parent reply other threads:[~2007-10-24 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 11:13 [patch 0/5] fuse fixes for 2.6.24 Miklos Szeredi
2007-10-24 11:13 ` Miklos Szeredi [this message]
2007-10-24 11:13 ` [patch 2/5] fuse: fix reading past EOF Miklos Szeredi
2007-10-24 11:13 ` [patch 3/5] fuse: cleanup: add fuse_get_attr_version() Miklos Szeredi
2007-10-24 11:13 ` [patch 4/5] fuse: pass open flags to read and write Miklos Szeredi
2007-10-24 11:13 ` [patch 5/5] fuse: fix FUSE_FILE_OPS sending Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024111425.536479203@szeredi.hu \
--to=miklos@szeredi.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®