From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Gilles Gigan <gilles.gigan@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: add Nano 7240 driver
Date: Wed, 24 Oct 2007 17:27:31 +0100 [thread overview]
Message-ID: <20071024172731.202fb478@the-village.bc.nu> (raw)
In-Reply-To: <20071024152240.GB6015@infomag.infomag.iguana.be>
On Wed, 24 Oct 2007 17:22:40 +0200
Wim Van Sebroeck <wim@iguana.be> wrote:
> Hi Andrew,
>
> > > + case WDIOC_SETOPTIONS:{
> > > + int retval = -EINVAL;
> > > +
> > > + if (arg & WDIOS_DISABLECARD) {
> > > + wdt_disable();
> > > + retval = 0;
> > > + }
> > > +
> > > + if (arg & WDIOS_ENABLECARD) {
> > > + wdt_enable();
> > > + retval = 0;
> > > + }
> > > +
> > > + return retval;
> >
> > hrm. So if userspace does ioctl(..., WDIOS_DISABLECARD|WDIOS_ENABLECARD,
> > that happens to be equivalent to WDIOS_ENABLECARD?
> >
> > Do all watchdog drivers do it exactly the same way, or are we offering
> > inconsistent interfaces between different drivers?
>
> I fear that all watchdog drivers do it more or less like this.
Not really an issue. "Mummy if I jump off a cliff it hurts"
next prev parent reply other threads:[~2007-10-24 16:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 2:11 Gilles Gigan
2007-10-24 2:29 ` Andrew Morton
2007-10-24 15:22 ` Wim Van Sebroeck
2007-10-24 16:27 ` Alan Cox [this message]
2007-10-31 6:31 ` Gilles Gigan
2007-10-24 15:16 ` Wim Van Sebroeck
-- strict thread matches above, loose matches on Subject: below --
2007-10-06 15:39 Gilles Gigan
2007-10-07 7:08 ` Andrey Panin
2007-10-07 12:49 ` Gilles Gigan
2007-10-15 19:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024172731.202fb478@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=gilles.gigan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®