From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Cc: Balbir Singh <balbir@linux.vnet.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [x86 patch] Fix UML ptrace-abi.h build error
Date: Thu, 25 Oct 2007 17:04:40 +0530 [thread overview]
Message-ID: <20071025113440.27531.47204.sendpatchset@balbir-laptop> (raw)
Fix the compilation error
arch/um/kernel/sysrq.c: In function 'show_stack':
arch/um/kernel/sysrq.c:63: error: 'UESP' undeclared (first use in this function)
arch/um/kernel/sysrq.c:63: error: (Each undeclared identifier is reported only once
arch/um/kernel/sysrq.c:63: error: for each function it appears in.)
make[1]: *** [arch/um/kernel/sysrq.o] Error 1
make: *** [arch/um/kernel] Error 2
Use BITS_PER_LONG == 32 instead of the hardcode __i386__ as UML depends on
this header.
Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---
include/asm-x86/ptrace-abi.h | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff -puN include/asm-x86/ptrace-abi.h~uml-fix-ptrace-abi-header include/asm-x86/ptrace-abi.h
--- 2.6.24-rc1/include/asm-x86/ptrace-abi.h~uml-fix-ptrace-abi-header 2007-10-25 17:01:47.000000000 +0530
+++ 2.6.24-rc1-balbir/include/asm-x86/ptrace-abi.h 2007-10-25 17:01:47.000000000 +0530
@@ -1,7 +1,9 @@
#ifndef _ASM_X86_PTRACE_ABI_H
#define _ASM_X86_PTRACE_ABI_H
-#ifdef __i386__
+#include <asm/types.h>
+
+#if BITS_PER_LONG == 32
#define EBX 0
#define ECX 1
@@ -22,7 +24,7 @@
#define SS 16
#define FRAME_SIZE 17
-#else /* __i386__ */
+#else /* BITS_PER_LONG == 32 */
#if defined(__ASSEMBLY__) || defined(__FRAME_OFFSETS)
#define R15 0
@@ -55,7 +57,7 @@
/* top of stack page */
#define FRAME_SIZE 168
-#endif /* !__i386__ */
+#endif /* !BITS_PER_LONG == 32 */
/* Arbitrarily choose the same ptrace numbers as used by the Sparc code. */
#define PTRACE_GETREGS 12
_
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
next reply other threads:[~2007-10-25 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 11:34 Balbir Singh [this message]
2007-10-27 3:21 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025113440.27531.47204.sendpatchset@balbir-laptop \
--to=balbir@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®