From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ide: fix drive_is_ready() for non-PCI hosts and CONFIG_IDEPCI_SHARE_IRQ=y
Date: Fri, 26 Oct 2007 01:35:17 +0100 [thread overview]
Message-ID: <20071026013517.0063e24a@the-village.bc.nu> (raw)
In-Reply-To: <200710260230.52115.bzolnier@gmail.com>
On Fri, 26 Oct 2007 02:30:52 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> On Friday 26 October 2007, Alan Cox wrote:
> > On Fri, 26 Oct 2007 01:36:37 +0200
> > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> >
> > >
> > > Need to check if the host is a PCI one before reading IDE_ALTSTATUS_REG.
> > >
> > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> >
> > Umm why ? The altstatus register goes back to ST-506 and the original IBM
> > XT hard disk controller card ?
>
> Thought that there have to be some (non-obvious) reason behing the fact that
> IDE_ALTSTATUS_REG reading was covered by #ifdef CONFIG_IDEPCI_SHARE_IRQ.
Only that reading altstatus is done to get the state without clearing the
IRQ which a status read would do.
Alan
next prev parent reply other threads:[~2007-10-26 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 23:36 Bartlomiej Zolnierkiewicz
2007-10-26 0:05 ` Alan Cox
2007-10-26 0:30 ` Bartlomiej Zolnierkiewicz
2007-10-26 0:35 ` Alan Cox [this message]
2007-10-26 0:42 ` Jeff Garzik
2007-10-26 11:53 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026013517.0063e24a@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®