From: Ingo Molnar <mingo@elte.hu>
To: "Simon Holm Thøgersen" <odie@cs.aau.dk>
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] raid6: generate raid6tables.c with proper style
Date: Fri, 26 Oct 2007 17:22:58 +0200 [thread overview]
Message-ID: <20071026152257.GB26619@elte.hu> (raw)
In-Reply-To: <1193397991.7078.5.camel@odie.local>
* Simon Holm Thøgersen <odie@cs.aau.dk> wrote:
> fre, 26 10 2007 kl. 10:17 +0200, skrev Ingo Molnar:
> > Subject: raid6: generate raid6tables.c with proper style
> > From: Ingo Molnar <mingo@elte.hu>
>
> [snip]
>
> > Index: linux/drivers/md/mktables.c
> > ===================================================================
> > --- linux.orig/drivers/md/mktables.c
> > +++ linux/drivers/md/mktables.c
> > @@ -69,7 +69,9 @@ int main(int argc, char *argv[])
> > for ( j = 0 ; j < 256 ; j += 8 ) {
> > printf("\t\t");
> > for ( k = 0 ; k < 8 ; k++ ) {
> > - printf("0x%02x, ", gfmul(i,j+k));
> > + if (k)
> > + printf(" ");
> > + printf("0x%02x,", gfmul(i,j+k));
>
> What happened with the coding style here?
i adopted to the existing (broken) one. Yes, mktables.c could need a
good cleanup too.
Ingo
next prev parent reply other threads:[~2007-10-26 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 8:17 Ingo Molnar
2007-10-26 11:26 ` Simon Holm Thøgersen
2007-10-26 15:22 ` Ingo Molnar [this message]
2007-10-26 17:01 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026152257.GB26619@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=odie@cs.aau.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®