From: Arjan van de Ven <arjan@infradead.org>
To: "lists@antonello.org" <lists@antonello.org>
Cc: Samuel Tardieu <sam@rfc1149.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight dimmer
Date: Sun, 28 Oct 2007 14:34:45 -0700 [thread overview]
Message-ID: <20071028143445.4617efd8@laptopd505.fenrus.org> (raw)
In-Reply-To: <4724FF8F.30306@antonello.org>
On Sun, 28 Oct 2007 22:30:55 +0100
"lists@antonello.org" <lists@antonello.org> wrote:
> Ok,
> now checkpatch.pl only complains about a missing signed-off-by.
> Is this ok for review?
hi,
when going over your patch.. is there a reason you introduce yet
another timeout infrastructure? Is there something wrong with the
existing ones that maybe should be fixed instead?
Either way.. please put justification for such new mechanism in the
patch changelog....
Greetings,
Arjan van de Ven
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2007-10-28 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 16:10 jack
2007-10-28 16:15 ` Samuel Tardieu
2007-10-28 21:30 ` lists
2007-10-28 21:34 ` Arjan van de Ven [this message]
2007-10-28 22:09 ` jack
2007-10-30 14:48 ` Pavel Machek
2007-11-01 23:18 ` jack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071028143445.4617efd8@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@antonello.org \
--cc=sam@rfc1149.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®