From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops
Date: Tue, 30 Oct 2007 08:08:27 +0800 [thread overview]
Message-ID: <20071030000827.GA9037@gondor.apana.org.au> (raw)
In-Reply-To: <20071029201627.GD7499@kernel.dk>
On Mon, Oct 29, 2007 at 09:16:27PM +0100, Jens Axboe wrote:
> On Fri, Oct 26 2007, Herbert Xu wrote:
> > [CRYPTO] tcrypt: Move sg_init_table out of timing loops
> >
> > This patch moves the sg_init_table out of the timing loops for hash
> > algorithms so that it doesn't impact on the speed test results.
>
> Wouldn't it be better to just make sg_init_one() call sg_init_table?
This looks fine to me although I think it's orthogonal to the
patch you were quoting :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-10-30 0:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 14:59 [0/2] [CRYPTO] users: Fix up remaining sg issues Herbert Xu
2007-10-26 15:00 ` [PATCH 1/2] [CRYPTO] tcrypt: Move sg_init_table out of timing loops Herbert Xu
2007-10-27 7:51 ` David Miller
2007-10-29 20:16 ` Jens Axboe
2007-10-30 0:08 ` Herbert Xu [this message]
2007-10-30 5:50 ` Jens Axboe
2007-10-30 14:18 ` Herbert Xu
2007-10-30 14:17 ` Jens Axboe
2007-10-30 9:31 ` Boaz Harrosh
2007-10-30 9:32 ` Jens Axboe
2007-10-26 15:00 ` [PATCH 2/2] [CRYPTO] users: Fix up scatterlist conversion errors Herbert Xu
2007-10-26 15:44 ` Vlad Yasevich
2007-10-27 7:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030000827.GA9037@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jens.axboe@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®