From: Andrew Morton <akpm@linux-foundation.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
bernie@codewiz.org
Subject: Re: [PATCH] Allow auto-destruction of loop devices.
Date: Tue, 30 Oct 2007 13:01:37 -0700 [thread overview]
Message-ID: <20071030130137.3345ae43.akpm@linux-foundation.org> (raw)
In-Reply-To: <1193612911.2915.80.camel@shinybook.infradead.org>
On Sun, 28 Oct 2007 19:08:31 -0400
David Woodhouse <dwmw2@infradead.org> wrote:
> This allows a flag to be set on loop devices so that when they are
> closed for the last time, they'll self-destruct.
>
Why do we want to do this?
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 56e2304..7fae828 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -973,6 +973,10 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
> lo->transfer = xfer->transfer;
> lo->ioctl = xfer->ioctl;
>
> + if ( (lo->lo_flags & LO_FLAGS_AUTOCLEAR) !=
> + (info->lo_flags & LO_FLAGS_AUTOCLEAR))
> + lo->lo_flags ^= LO_FLAGS_AUTOCLEAR;
> +
> lo->lo_encrypt_key_size = info->lo_encrypt_key_size;
> lo->lo_init[0] = info->lo_init[0];
> lo->lo_init[1] = info->lo_init[1];
> @@ -1331,6 +1335,10 @@ static int lo_release(struct inode *inode, struct file *file)
>
> mutex_lock(&lo->lo_ctl_mutex);
> --lo->lo_refcnt;
> +
> + if ((lo->lo_flags & LO_FLAGS_AUTOCLEAR) && !lo->lo_refcnt)
> + loop_clr_fd(lo, inode->i_bdev);
> +
> mutex_unlock(&lo->lo_ctl_mutex);
>
> return 0;
> diff --git a/include/linux/loop.h b/include/linux/loop.h
> index 26a0a10..46169a7 100644
> --- a/include/linux/loop.h
> +++ b/include/linux/loop.h
> @@ -76,6 +76,7 @@ struct loop_device {
> enum {
> LO_FLAGS_READ_ONLY = 1,
> LO_FLAGS_USE_AOPS = 2,
> + LO_FLAGS_AUTOCLEAR = 4,
> };
>
> #include <asm/posix_types.h> /* for __kernel_old_dev_t */
>
> --
> dwmw2
next prev parent reply other threads:[~2007-10-30 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 23:08 David Woodhouse
2007-10-30 20:01 ` Andrew Morton [this message]
2007-10-30 20:05 ` Jan Engelhardt
2007-10-30 20:12 ` David Woodhouse
2007-10-30 20:17 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030130137.3345ae43.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bernie@codewiz.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome