From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755560AbXJ3OwO (ORCPT ); Tue, 30 Oct 2007 10:52:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753340AbXJ3Ov5 (ORCPT ); Tue, 30 Oct 2007 10:51:57 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:33674 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752990AbXJ3Ov4 (ORCPT ); Tue, 30 Oct 2007 10:51:56 -0400 Date: Tue, 30 Oct 2007 08:51:55 -0600 From: Matthew Wilcox To: Richard Knutsson Cc: James.Bottomley@SteelEye.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean Message-ID: <20071030145155.GL32359@parisc-linux.org> References: <20071030104806.30936.13253.sendpatchset@thinktank.campus.ltu.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071030104806.30936.13253.sendpatchset@thinktank.campus.ltu.se> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: > Convert to use the generic boolean. > - u8 initialized; > - u8 in_use; /* is the management node open*/ > + bool initialized:8; > + bool in_use:8; /* is the management node open*/ Are you serious? -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."