From: Andy Whitcroft <apw@shadowen.org>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org,
Keiichi Kii <k-keiichi@bx.jp.nec.com>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH 5/6] fix typo in SubmittingPatches
Date: Wed, 31 Oct 2007 09:17:39 +0000 [thread overview]
Message-ID: <20071031091739.GB12619@shadowen.org> (raw)
In-Reply-To: <1193807505-3821-5-git-send-email-gregkh@suse.de>
On Tue, Oct 30, 2007 at 10:11:44PM -0700, Greg Kroah-Hartman wrote:
> From: Keiichi Kii <k-keiichi@bx.jp.nec.com>
>
> Fix typo.
>
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Andy Whitcroft <apw@shadowen.org>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Andy Whitcroft <apw@shadowen.org>
> ---
> Documentation/SubmittingPatches | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index a30dd44..681e2b3 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -464,8 +464,8 @@ section Linus Computer Science 101.
> Nuff said. If your code deviates too much from this, it is likely
> to be rejected without further review, and without comment.
>
> -Once significant exception is when moving code from one file to
> -another in this case you should not modify the moved code at all in
> +One significant exception is when moving code from one file to
> +another -- in this case you should not modify the moved code at all in
> the same patch which moves it. This clearly delineates the act of
> moving the code and your changes. This greatly aids review of the
> actual differences and allows tools to better track the history of
-apw
next prev parent reply other threads:[~2007-10-31 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 5:09 [GIT PATCH] driver core fixes for 2.6.24-rc1 Greg KH
2007-10-31 5:11 ` [PATCH 1/6] Driver core: remove class_device_*_bin_file Greg Kroah-Hartman
2007-10-31 5:11 ` [PATCH 2/6] kobject: check for duplicate names in kobject_rename Greg Kroah-Hartman
2007-10-31 5:11 ` [PATCH 3/6] sysfs: make sysfs_{get,put}_active() static Greg Kroah-Hartman
2007-10-31 5:11 ` [PATCH 4/6] Driver Core: fix bug in device_rename() for SYSFS_DEPRECATED=y Greg Kroah-Hartman
2007-10-31 5:11 ` [PATCH 5/6] fix typo in SubmittingPatches Greg Kroah-Hartman
2007-10-31 5:11 ` [PATCH 6/6] add SubmittingPatches to Documentation/ja_JP Greg Kroah-Hartman
2007-10-31 9:17 ` Andy Whitcroft [this message]
2007-10-31 17:26 ` [PATCH 1/6] Driver core: remove class_device_*_bin_file Tony Luck
2007-10-31 18:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031091739.GB12619@shadowen.org \
--to=apw@shadowen.org \
--cc=gregkh@suse.de \
--cc=k-keiichi@bx.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®