mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Greg KH <greg@kroah.com>,
	James Bottomley <James.Bottomley@SteelEye.com>,
	Kay Sievers <kay.sievers@vrfy.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sysfs: add filter function to groups
Date: Wed, 31 Oct 2007 13:19:47 +0100	[thread overview]
Message-ID: <20071031131947.35a521c9@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <47285AF0.1010900@s5r6.in-berlin.de>

On Wed, 31 Oct 2007 11:37:36 +0100,
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:

> > mask_out() would also imply that the common use case is to have all
> > attributes in the group created and that you need to take action to
> > have an attribute not created.
> 
> Here you have a point.  But James has a point too when he says:
> | We basically want to show capability by which file is present.

Currently, if you register an attribute group, all of the attributes
will show up. I find it more intuitive to have to block some attributes
explicitely if I want to have more control, but the original logic is
fine with me as well, if most people prefer that :)

> Anyway, /if/ the reverse logic is preferred, it shouldn't be called
> "mask_out()" but rather "is_masked()" or "is_hidden()" or the like.

Sure. is_masked() would be fine.


  reply	other threads:[~2007-10-31 12:20 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 15:16 James Bottomley
2007-10-29 16:54 ` Kay Sievers
2007-10-29 16:57   ` James Bottomley
2007-10-29 17:18     ` Cornelia Huck
2007-10-29 17:24       ` James Bottomley
2007-10-29 17:27         ` Jeff Garzik
2007-10-29 17:29           ` James Bottomley
2007-10-30  9:00             ` Cornelia Huck
2007-10-30  8:55         ` Cornelia Huck
2007-10-29 17:27     ` Kay Sievers
2007-10-29 17:28       ` James Bottomley
2007-10-29 17:43         ` Kay Sievers
2007-10-29 17:58     ` Stefan Richter
2007-10-29 18:12       ` James Bottomley
2007-10-30 18:25       ` James Bottomley
2007-10-30 19:31         ` Stefan Richter
2007-10-30 19:47         ` Kay Sievers
2007-10-31  0:40         ` Mark M. Hoffman
2007-10-31  2:01           ` Kay Sievers
2007-10-31 11:28             ` Mark M. Hoffman
2007-10-31  3:55         ` Greg KH
2007-10-31  9:41           ` Cornelia Huck
2007-10-31  9:52             ` Stefan Richter
2007-10-31 10:20               ` Cornelia Huck
2007-10-31 10:37                 ` Stefan Richter
2007-10-31 12:19                   ` Cornelia Huck [this message]
2007-10-31 14:38           ` James Bottomley
2007-10-31 17:29             ` Greg KH
2007-11-04 14:12               ` James Bottomley
2007-11-04 19:06                 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071031131947.35a521c9@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®