From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Serge Hallyn <sergeh@us.ibm.com>, Trent Jaeger <jaegert@us.ibm.com>
Cc: Venkat Yekkirala <vyekkirala@TrustedCS.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
James Morris <jmorris@namei.org>,
Eric Paris <eparis@parisplace.org>,
<linux-kernel@vger.kernel.org>, <selinux@tycho.nsa.gov>
Subject: [PATCH] selinux: suppress a warning for 64k pages.
Date: Wed, 31 Oct 2007 14:57:44 +1100 [thread overview]
Message-ID: <20071031145744.6dd02cc7.sfr@canb.auug.org.au> (raw)
On PowerPC allmodconfig build we get this:
security/selinux/xfrm.c:214: warning: comparison is always false due to limited range of data type
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
security/selinux/xfrm.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
diff --git a/security/selinux/xfrm.c b/security/selinux/xfrm.c
index 36a191e..602beb0 100644
--- a/security/selinux/xfrm.c
+++ b/security/selinux/xfrm.c
@@ -211,8 +211,11 @@ static int selinux_xfrm_sec_ctx_alloc(struct xfrm_sec_ctx **ctxp,
if (uctx->ctx_doi != XFRM_SC_ALG_SELINUX)
return -EINVAL;
+ /* ctx_len is __u16 */
+#if PAGE_SIZE < (1 << 16)
if (uctx->ctx_len >= PAGE_SIZE)
return -ENOMEM;
+#endif
*ctxp = ctx = kmalloc(sizeof(*ctx) +
uctx->ctx_len + 1,
--
1.5.3.4
next reply other threads:[~2007-10-31 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 3:57 Stephen Rothwell [this message]
2007-10-31 5:47 ` [PATCHv2] " Stephen Rothwell
2007-10-31 13:41 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031145744.6dd02cc7.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=eparis@parisplace.org \
--cc=jaegert@us.ibm.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=sergeh@us.ibm.com \
--cc=vyekkirala@TrustedCS.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®