mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH/RFC] x86: unify Kconfig files
Date: Thu, 1 Nov 2007 06:25:13 +0100	[thread overview]
Message-ID: <20071101052513.GB31445@uranus.ravnborg.org> (raw)
In-Reply-To: <47295123.9010603@goop.org>

On Wed, Oct 31, 2007 at 09:08:03PM -0700, Jeremy Fitzhardinge wrote:
> Sam Ravnborg wrote:
> > It has been requested that we should let x86 behave like
> > other architectures so we at config time decide for 32 or 64 bit.
> > The challenge here is to mere the Kconfig files and I have done
> > an attempt to do so.
> >
> > +source "mm/Kconfig"
> >  
> > -config X86_VISWS_APIC
> > +config HIGHPTE
> > +	bool "Allocate 3rd-level pagetables from highmem"
> > +	depends on X86_32 && HIGHMEM4G || HIGHMEM64G
> >   
> 
> Some parens: X86_32 && (HIGHMEM4G || HIGHMEM64G)?

Yes - thanks.

This particular X86_32 dependency is for documentation only since
HIGHMEM4G and HIGHMEM64G is a X86_32 thing only.
But depite this is should be correct.
I will audit the other dependencies for the same bug.

	Sam

  reply	other threads:[~2007-11-01  5:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 21:55 Sam Ravnborg
2007-11-01  4:08 ` Jeremy Fitzhardinge
2007-11-01  5:25   ` Sam Ravnborg [this message]
2007-11-01 21:14 ` Sam Ravnborg
2007-11-01 21:21   ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071101052513.GB31445@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®