From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata ATAPI transfer size cleanups
Date: Thu, 1 Nov 2007 10:59:02 +0000 [thread overview]
Message-ID: <20071101105902.6e411c20@the-village.bc.nu> (raw)
In-Reply-To: <4729A23E.7000601@garzik.org>
On Thu, 01 Nov 2007 05:54:06 -0400
Jeff Garzik <jeff@garzik.org> wrote:
> Alan Cox wrote:
> > On Thu, 1 Nov 2007 05:07:33 -0400
> > Jeff Garzik <jeff@garzik.org> wrote:
> >
> >> This is purely for comment and testing, not for merging (yet?).
> >>
> >> A common recipe in several vendor drivers (either GPL'd, or I have NDA'd
> >> access to use them as a documentation-like reference) for ATAPI was
> >> slightly different from ours. This recipe can be found in
> >> atapi_tf_xfer_size(), and it's slightly different from Alan's.
> >
> > Looks mostly good. Might cause breakage on one or two controllers by
> > setting lbam/lbah to 0 for DMA but we can test that and find out.
>
> DMA always zeroed lbam/lbah thanks to memset(), my patch merely made it
> explicit.
That would be a bug if so - need to try fixing that and see if it sorts
out the remaining recalcitrant ALi chips.
Alan
next prev parent reply other threads:[~2007-11-01 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 9:07 Jeff Garzik
2007-11-01 9:43 ` Alan Cox
2007-11-01 9:54 ` Jeff Garzik
2007-11-01 10:59 ` Alan Cox [this message]
2007-11-01 19:51 ` Torsten Kaiser
2007-11-02 5:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101105902.6e411c20@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®