From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup
Date: Thu, 1 Nov 2007 15:48:47 +0000 [thread overview]
Message-ID: <20071101154847.570d8e96@the-village.bc.nu> (raw)
In-Reply-To: <15530290543226725036.slaby@karneval.cz>
On Thu, 1 Nov 2007 11:55:56 +0100 (CET)
Jiri Slaby <jirislaby@gmail.com> wrote:
> tty, add tty_schedule_wakeup
>
> Because several drivers schedule a workqueue only for tty_wakeup, move this
> functionality into tty layer and use newly added centralized work.
I've no idea why any drivers do this. A tty_wakeup is very fast and it
won't (when called from an IRQ) reschedule anything until the IRQ is over
(in the RT kernel case it might do stuff but thats *because* it should do
so).
I think just using tty_wakeup for this ought to be sufficient unless they
are using the work queue for some kind of serialization of events
next prev parent reply other threads:[~2007-11-01 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 10:55 [RFC 1/2] Char: tty, centralize works Jiri Slaby
2007-11-01 10:55 ` [PATCH 2/2] Char: tty, add tty_schedule_wakeup Jiri Slaby
2007-11-01 14:34 ` Paul Fulghum
2007-11-01 15:07 ` Jiri Slaby
2007-11-01 15:48 ` Alan Cox [this message]
2007-11-01 15:50 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101154847.570d8e96@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®