From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Swen Schillig <swen@vnet.ibm.com>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
Christof Schmitt <christof.schmitt@de.ibm.com>,
linux-scsi@vger.kernel.org,
Linux on 390 Port <LINUX-390@vm.marist.edu>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zfcp: add some internal zfcp adapter statistics
Date: Sat, 3 Nov 2007 10:40:58 +0100 [thread overview]
Message-ID: <20071103094058.GA25134@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20071103091722.GA7807@osiris.boeblingen.de.ibm.com>
> > + if (!(adapter->adapter_features & FSF_FEATURE_MEASUREMENT_DATA)) {
> > + ZFCP_LOG_NORMAL("error: Enhanced measurement feature not "
> > + "supported");
> > + return -EOPNOTSUPP;
> > + }
Btw. any user can flood the console with these messages if the adapter
doesn't support the feature. That can be considered a denial of service
attack. Please just return -EOPNOTSUPP and don't print anything on the
console.
next prev parent reply other threads:[~2007-11-03 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 10:33 Swen Schillig
2007-11-03 9:17 ` Heiko Carstens
2007-11-03 9:40 ` Heiko Carstens [this message]
2007-11-05 11:35 ` Swen Schillig
2007-11-05 15:12 ` Swen Schillig
2007-11-25 11:16 ` James Bottomley
2007-11-26 10:23 ` Swen Schillig
2007-12-06 9:40 ` Swen Schillig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071103094058.GA25134@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=James.Bottomley@steeleye.com \
--cc=LINUX-390@vm.marist.edu \
--cc=christof.schmitt@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=swen@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome