mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Dave Jones <davej@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/10] x86: unification of cfufreq/Kconfig
Date: Tue, 6 Nov 2007 09:13:39 +0100	[thread overview]
Message-ID: <20071106081339.GA5687@uranus.ravnborg.org> (raw)
In-Reply-To: <20071106073821.GA12733@redhat.com>

>  > +	depends on X86_32 && X86_ELAN
>  >  	---help---
>  >  	  This adds the CPUFreq driver for AMD Elan SC520 processor.
> 
> X86_ELAN should depend on X86_32 rather than adding this everywhere.

...

>  >  	bool
>  >  	depends on X86_POWERNOW_K7 && ACPI_PROCESSOR
>  >  	depends on !(X86_POWERNOW_K7 = y && ACPI_PROCESSOR = m)
>  > +	depends on X86_32
>  >  	default y
> 
> This 2nd hunk shouldn't be necessary, as it depends on X86_POWERNOW_K7
> which you just added the 32bit dependancy to. 
> 
>  >  config X86_SPEEDSTEP_RELAXED_CAP_CHECK
>  >  	bool "Relaxed speedstep capability checks"
>  > -	depends on (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
>  > +	depends on X86_32 && (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
> 
> Should also be unnecessary due to those items now being 32bit dependant.

In several cases the "depends on X86_32 were added not as a necessity
but just to make it obvious that a given symbol is 32 bit specific.
I can drop doing it this way if it is anyway obvious from the context.

Will try to do so in next patch-set, due tonigt if things goes OK.

	Sam

  reply	other threads:[~2007-11-06  8:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-03 23:51 Sam Ravnborg
2007-11-03 23:51 ` [PATCH 02/10] x86: start unification of arch/x86/Kconfig.* Sam Ravnborg
2007-11-03 23:51   ` [PATCH 03/10] x86: arch/x86/Kconfig.cpu unification Sam Ravnborg
2007-11-03 23:51     ` [PATCH 04/10] x86: add X86_32 dependency to i386 specific symbols in Kconfig.i386 Sam Ravnborg
2007-11-03 23:51       ` [PATCH 05/10] x86: add X86_64 dependency to x86_64 specific symbols in Kconig.x86_64 Sam Ravnborg
2007-11-03 23:51         ` [PATCH 06/10] x86: copy x86_64 specific Kconfig symbols to Kconifg.i386 Sam Ravnborg
2007-11-03 23:51           ` [PATCH 07/10] x86: add remaning bits from x86_64 to Kconfig.i386 Sam Ravnborg
2007-11-03 23:51             ` [PATCH 08/10] x86: combine all config options with prompts in Kconfig Sam Ravnborg
2007-11-03 23:51               ` [PATCH 09/10] x86: select i386 or x86_64 at config time Sam Ravnborg
2007-11-03 23:51                 ` [PATCH 10/10] x86: enable make ARCH=x86 Sam Ravnborg
2007-11-06  0:53     ` [PATCH 03/10] x86: arch/x86/Kconfig.cpu unification Brian Gerst
2007-11-06  2:46       ` Sam Ravnborg
2007-11-06  2:52         ` Adrian Bunk
2007-11-06  7:10           ` Brian Gerst
2007-11-04  1:44   ` [PATCH 02/10] x86: start unification of arch/x86/Kconfig.* Adrian Bunk
2007-11-04 18:07     ` Sam Ravnborg
2007-11-04  1:28 ` [PATCH 01/10] x86: unification of cfufreq/Kconfig Adrian Bunk
2007-11-04  8:35   ` Sam Ravnborg
2007-11-06  7:38 ` Dave Jones
2007-11-06  8:13   ` Sam Ravnborg [this message]
2007-11-06 10:49     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071106081339.GA5687@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=davej@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®