mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>, adaplas@gmail.com
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Andy Whitcroft <apw@shadowen.org>
Subject: [PATCH] chipsfb: uses/depends on PCI
Date: Wed, 7 Nov 2007 13:15:03 -0800	[thread overview]
Message-ID: <20071107131503.11c68fbd.randy.dunlap@oracle.com> (raw)
In-Reply-To: <4732186D.1010502@linux.vnet.ibm.com>

From: Randy Dunlap <randy.dunlap@oracle.com>

chipsfb uses PCI interfaces and should depend on PCI.

  CC      drivers/video/chipsfb.o
drivers/video/chipsfb.c: In function 'chipsfb_pci_init':
drivers/video/chipsfb.c:378: error: implicit declaration of function 'pci_request_region'
drivers/video/chipsfb.c:435: error: implicit declaration of function 'pci_release_region'
make[2]: *** [drivers/video/chipsfb.o] Error 1
make[1]: *** [drivers/video] Error 2
make: *** [drivers] Error 2

!CONFIG_PCI causes the build to fail.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 drivers/video/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2624-rc1-mmbo.orig/drivers/video/Kconfig
+++ linux-2624-rc1-mmbo/drivers/video/Kconfig
@@ -503,7 +503,7 @@ config FB_VALKYRIE
 
 config FB_CT65550
 	bool "Chips 65550 display support"
-	depends on (FB = y) && PPC32
+	depends on (FB = y) && PPC32 && PCI
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT

  reply	other threads:[~2007-11-07 21:17 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06 10:33 mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded akpm
2007-11-06 12:57 ` mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build fails on powerpc Kamalesh Babulal
2007-11-06 15:56   ` Badari Pulavarty
2007-11-06 13:17 ` [-mm patch] fix getblk_slow "integer constant is too large" warning Frederik Deweerdt
2007-11-06 13:51 ` mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded Gabriel C
2007-11-06 15:10 ` mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - S390x build fails Kamalesh Babulal
2007-11-06 15:29   ` Cornelia Huck
2007-11-06 16:42     ` Cornelia Huck
2007-11-06 19:58       ` Kamalesh Babulal
2007-11-06 21:10   ` Andrew Morton
2007-11-06 21:13     ` Greg KH
2007-11-06 22:33       ` Andrew Morton
2007-11-06 21:39         ` Greg KH
2007-11-06 15:34 ` mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs Kamalesh Babulal
2007-11-06 18:19   ` Badari Pulavarty
2007-11-06 19:46     ` Kamalesh Babulal
2007-11-06 21:05     ` Greg KH
2007-11-06 19:31   ` Greg KH
2007-11-06 19:39   ` Greg KH
2007-11-06 16:51 ` [BUG] mm snapshot broken-out-2007-11-06-02-32.tar.gz - soft lockup Kamalesh Babulal
2007-11-06 17:16   ` Balbir Singh
2007-11-06 17:27 ` [BUG] mm snapshot broken-out-2007-11-06-02-32 - kernel oops Kamalesh Babulal
2007-11-06 18:17 ` mm snapshot broken-out-2007-11-06-02-32 - powerpc link failure Kamalesh Babulal
2007-11-06 19:00   ` Badari Pulavarty
2007-11-06 18:36 ` mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded Badari Pulavarty
2007-11-06 19:46   ` Greg KH
2007-11-06 19:32 ` Badari Pulavarty
2007-11-06 21:17   ` Greg KH
2007-11-06 20:14 ` Gabriel C
2007-11-06 21:40   ` Andrew Morton
2007-11-06 21:07     ` Greg KH
2007-11-06 22:15       ` Andrew Morton
2007-11-06 21:33         ` Greg KH
2007-11-06 22:41           ` Andrew Morton
2007-11-06 21:51             ` Greg KH
2007-11-12 20:17       ` Serge E. Hallyn
2007-11-16 20:57         ` Greg KH
2007-11-06 21:40 ` mm snapshot broken-out-2007-11-06-02-32 - ACPI functions broken Kamalesh Babulal
2007-11-07 12:29   ` Jean Delvare
2007-11-07 17:13     ` Kamalesh Babulal
2007-11-07 18:37 ` mm snapshot broken-out-2007-11-06-02-32 build failure init/do_mount Kamalesh Babulal
2007-11-07 20:39   ` Greg KH
2007-11-07 19:52 ` mm snapshot broken-out-2007-11-06-02-32 powerpc - axon_msi build faliure Kamalesh Babulal
2007-11-07 20:28   ` Benjamin Herrenschmidt
2007-11-07 20:35     ` Kamalesh Babulal
2007-11-07 19:56 ` mm snapshot broken-out-2007-11-06-02-32 build failure !CONFIG_PCI Kamalesh Babulal
2007-11-07 21:15   ` Randy Dunlap [this message]
2007-11-07 20:42 ` mm snapshot broken-out-2007-11-06-02-32 make header check fails Kamalesh Babulal
2007-11-07 21:55   ` Andrew Morton
2007-11-07 20:57 ` mm snapshot broken-out-2007-11-06-02-32 build failure - !CONFIG_PPC_ISERIES Kamalesh Babulal
2007-11-08  2:27   ` Tony Breeds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071107131503.11c68fbd.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=adaplas@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®