From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762069AbXKHVER (ORCPT ); Thu, 8 Nov 2007 16:04:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761251AbXKHVEG (ORCPT ); Thu, 8 Nov 2007 16:04:06 -0500 Received: from waste.org ([66.93.16.53]:60806 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758686AbXKHVEF (ORCPT ); Thu, 8 Nov 2007 16:04:05 -0500 Date: Thu, 8 Nov 2007 15:03:48 -0600 From: Matt Mackall To: Christoph Lameter Cc: Mel Gorman , akpm@linux-foundatin.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch 02/23] SLUB: Rename NUMA defrag_ratio to remote_node_defrag_ratio Message-ID: <20071108210348.GX19691@waste.org> References: <20071107011130.382244340@sgi.com> <20071107011226.844437184@sgi.com> <20071108145044.GB2591@skynet.ie> <20071108172548.GW17536@waste.org> <20071108194735.GW19691@waste.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 08, 2007 at 12:01:24PM -0800, Christoph Lameter wrote: > On Thu, 8 Nov 2007, Matt Mackall wrote: > > > Not really. drivers/char/random.c does: > > > > __get_cpu_var(trickle_count)++ & 0xfff > > That is incremented on each call to add_timer_randomness. Not a high > enough resolution there. I guess I am stuck with get_cycles(). I'm not suggesting you use trickle_count, silly. I'm suggesting you use a similar approach. But perhaps I should just add a lightweight RNG to random.c and be done with it. -- Mathematics is the supreme nostalgia of our time.