From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Frank Seidel <fseidel@suse.de>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com,
p.hardwick@option.com, Marcel Holtmann <marcel@holtmann.org>
Subject: Re: nozomi version 2.1c for review
Date: Fri, 9 Nov 2007 14:25:00 +0000 [thread overview]
Message-ID: <20071109142500.0201fe4a@the-village.bc.nu> (raw)
In-Reply-To: <200711091449.24648.fseidel@suse.de>
> and already in Gregs git repository) i resolved and removed all those
> GET_* and SET_* macros.
Oh good, that was long overdue.
> + switch (port) {
> + case PORT_MDM:
> + dc->last_ier = (dc->last_ier & ~MDM_UL) | MDM_UL;
> + break;
The & ~xxx is unneeded if you then set it again always
Could also clean up to be
u8 mask[NR_PORTS] = { DIAG_UGL, APP1_UL, ... }
dc->last_ier |= mask[port];
instead of the switch - ditto disable transmit_ul etc
> + case PORT_DIAG:
> + dc->last_ier = (dc->last_ier & ~DIAG_UL) | DIAG_UL;
> + break;
> + case PORT_APP1:
> + dc->last_ier = (dc->last_ier & ~APP1_UL) | APP1_UL;
Looking a lot better than before and with plenty of scope for more
improvement now it can be read.
Alan
next prev parent reply other threads:[~2007-11-09 14:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 13:49 Frank Seidel
2007-11-09 14:25 ` Alan Cox [this message]
2007-11-09 23:27 ` Frank Seidel
2007-11-10 15:52 ` Frank Seidel
2007-11-11 16:43 ` [RFC] Re: nozomi version 2.1d " Frank Seidel
2007-11-12 18:43 ` Frank Seidel
2007-11-26 1:28 ` Michael Lothian
2007-11-26 11:04 ` Frank Seidel
[not found] ` <fc94aae90711271220k3684e7a1x9ec0b2e9c1db78e2@mail.gmail.com>
2007-11-27 22:12 ` Greg KH
2007-11-28 5:04 ` Frank Seidel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109142500.0201fe4a@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=fseidel@suse.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=p.hardwick@option.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®