From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/7] Char: rocket, printk cleanup
Date: Fri, 9 Nov 2007 23:41:11 +0000 [thread overview]
Message-ID: <20071109234111.73bdb0b0@the-village.bc.nu> (raw)
In-Reply-To: <25731202891966530041.slaby@pripojeni.net>
> - printk(KERN_INFO "rp_do_receive(%d)...", ToRecv);
> + printk(KERN_INFO "rp_do_receive(%d)...\n", ToRecv);
The missing \n was intentional looking at the old code, and meant you got
a lot of trace per line for debugging. The KERN_ additions are the
breakage here.
We might as well just lose them, we have proper debuggers now and they
are useless with \n, and pretty useless without.
next prev parent reply other threads:[~2007-11-09 23:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 23:34 [PATCH 1/7] Char: rocket, switch long delay to sleep Jiri Slaby
2007-11-09 23:35 ` [PATCH 2/7] Char: rocket, printk cleanup Jiri Slaby
2007-11-09 23:41 ` Alan Cox [this message]
2007-11-09 23:36 ` [PATCH 3/7] Char: rocket, remove useless macros Jiri Slaby
2007-11-09 23:42 ` Alan Cox
2007-11-09 23:36 ` [PATCH 4/7] Char: char/serial, remove SERIAL_TYPE_NORMAL redefines Jiri Slaby
2007-11-09 23:37 ` [PATCH 5/7] Char: mxser_new, ioaddresses are ulong Jiri Slaby
2007-11-09 23:38 ` [PATCH 6/7] Char: stallion, fix compiler warnings Jiri Slaby
2007-11-09 23:38 ` [PATCH 7/7] Char: riscom8, change rc_init_drivers prototype Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109234111.73bdb0b0@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®