From: Christoph Hellwig <hch@infradead.org>
To: Thomas Koeller <thomas@koeller.dyndns.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Include header required for INT_MAX
Date: Sat, 10 Nov 2007 15:56:13 +0000 [thread overview]
Message-ID: <20071110155613.GB22418@infradead.org> (raw)
In-Reply-To: <20071110145627.C6FE347A7C@mail.koeller.dyndns.org>
On Sat, Nov 10, 2007 at 03:55:15PM +0100, Thomas Koeller wrote:
> cdrom.h uses INT_MAX, so it must include kernel.h or
> limits.h (userspace) for a definition.
Nack, we shoiuld never include userspace headers in kernel headers,
an even more never add !__KERNEL__ ifdefs. Just make sure your
programs include limit.h before including linux/cdrom.h.
next prev parent reply other threads:[~2007-11-10 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 14:55 Thomas Koeller
2007-11-10 15:56 ` Christoph Hellwig [this message]
2007-11-11 0:52 ` Thomas Koeller
2007-11-10 16:48 ` Alexander E. Patrakov
2007-11-11 22:52 Jan Engelhardt
2007-11-12 10:21 ` Peter Zijlstra
2007-11-12 10:46 ` Andreas Schwab
2007-11-12 10:51 ` Robert P. J. Day
2007-11-12 12:06 ` Andreas Schwab
2007-11-12 12:57 ` Vegard Nossum
2007-11-12 13:37 ` Jan Engelhardt
2007-11-12 20:50 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071110155613.GB22418@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas@koeller.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®