From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mikael.starvik@axis.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CRISv10 improve and bugfix fasttimer
Date: Wed, 14 Nov 2007 17:16:13 +0100 [thread overview]
Message-ID: <20071114161613.GL6347@axis.com> (raw)
In-Reply-To: <20071112154456.GH6347@axis.com>
On Mon, Nov 12, 2007 at 04:44:56PM +0100, Jesper Nilsson wrote:
> On Fri, Nov 09, 2007 at 03:19:32PM -0800, Andrew Morton wrote:
> > > if (timeval_cmp(&t->tv_expires, &tv) <= 0)
> >
> > You have a private timeval_cmp(). Please take a look at utilising
> > include/linux/time.h:timeval_compare() instead. If that doesn't suit then
> > we'd entertain extensions of that interface. Adding private code to do
> > something as common as this is not a good thing.
Unfortunately, the above code lies to us.
The comparison is no longer on timeval, but on a fasttimer_t,
which contains different data. The name is just a leftover from when
it was a timeval.
I'll change the name of the function to highlight this.
Best regards,
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2007-11-14 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 8:54 Jesper Nilsson
2007-11-09 23:19 ` Andrew Morton
2007-11-12 15:44 ` Jesper Nilsson
2007-11-14 16:16 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114161613.GL6347@axis.com \
--to=jesper.nilsson@axis.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®