mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Alexey Dobriyan <adobriyan@sw.ru>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: EIP is at device_shutdown+0x32/0x60
Date: Thu, 15 Nov 2007 14:15:36 +0100	[thread overview]
Message-ID: <20071115141536.696e3611@gondolin.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20071115213345.B3C1.Y-GOTO@jp.fujitsu.com>

On Thu, 15 Nov 2007 21:55:34 +0900,
Yasunori Goto <y-goto@jp.fujitsu.com> wrote:

> /**
>  * device_shutdown - call ->shutdown() on each device to shutdown.
>  */
> void device_shutdown(void)
> {
>         struct device * dev, *devn;
> 
>         list_for_each_entry_safe_reverse(dev, devn, &devices_kset->list,
>                                 kobj.entry) {
>                 if (dev->bus && dev->bus->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->bus->shutdown(dev);
>                 } else if (dev->driver && dev->driver->shutdown) {
>                         dev_dbg(dev, "shutdown\n");
>                         dev->driver->shutdown(dev);
>                 }
>         }
> }
> --------
> When oops occured, dev->driver pointed kset_ktype's address,
> and dev->driver->shutdown was the address of bus_type_list.
> So, Oops was caused by "Illegal operation fault".
> kset_ktypes is pointed by system_kset.
> 
> If my understanding is correct, this loop can't distinguish between
> struct device and struct kset, but both are connected in this list,
> right? It may be the cause of this.

Uh. This fits with my observations on s390 as well (the list is not
corrupted, but it contains entities that are not devices...)

The other entries under /sys/devices (on my system css0, platform,
qeth) are all struct devices. This sysdev stuff is headache-inducing :(

  reply	other threads:[~2007-11-15 13:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15  9:11 Alexey Dobriyan
2007-11-15  9:44 ` Andrew Morton
2007-11-15  9:59   ` Alexey Dobriyan
2007-11-15 12:55   ` Yasunori Goto
2007-11-15 13:15     ` Cornelia Huck [this message]
2007-11-15 16:34     ` Greg KH
2007-11-15 17:07       ` Mark Lord
2007-11-15 18:23         ` Greg KH
2007-11-15 18:29           ` Mark Lord
2007-11-15 18:48             ` Greg KH
2007-11-15 19:13               ` Mark Lord
2007-11-15 17:50       ` Kay Sievers
2007-11-15 18:18         ` Greg KH
2007-11-15 19:01         ` Greg KH
2007-11-16  1:13           ` Yasunori Goto
2007-11-16  1:22             ` Greg KH
2007-11-19  9:55               ` Cornelia Huck
2007-11-15 14:40   ` Jeff Dike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071115141536.696e3611@gondolin.boeblingen.de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=adobriyan@sw.ru \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=y-goto@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®