From: Muli Ben-Yehuda <muli@il.ibm.com>
To: mark gross <mgross@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
torvalds@linux-foundation.org
Subject: Re: [PATCH]intel-iommu-PMEN support
Date: Sat, 17 Nov 2007 10:52:41 +0200 [thread overview]
Message-ID: <20071117085241.GG4380@rhun.haifa.ibm.com> (raw)
In-Reply-To: <20071116223957.GA26796@linux.intel.com>
On Fri, Nov 16, 2007 at 02:39:57PM -0800, mark gross wrote:
> The following patch adds support for protected memory enable bits by
> clearing them if they are set at startup time. Some future boot
> loaders or firmware could have this bit set after it loads the
> kernel, and it needs to be cleared if DMA's are going to happen
> effectively.
>
> please apply
>
> --mgross
>
> Signed-off-by: mark gross <mgross@intel.com>
Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
Mark, please try in the future to not mix unrelated changes such as
these. This patch should've been two patches, one to disable protected
memory enable and the other to do the cleanups.
> -#define MAX_FAULT_REASON_IDX ARRAY_SIZE(fault_reason_strings) - 1
> +#define MAX_FAULT_REASON_IDX (ARRAY_SIZE(fault_reason_strings) - 1)
> -static inline u64 dmar_readq(void *addr)
> +static inline u64 dmar_readq(void __iomem *addr)
Cheers,
Muli
next prev parent reply other threads:[~2007-11-17 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 22:39 mark gross
2007-11-17 8:52 ` Muli Ben-Yehuda [this message]
2007-11-20 0:38 ` Andrew Morton
2007-11-20 17:59 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071117085241.GG4380@rhun.haifa.ibm.com \
--to=muli@il.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome