From: Jeff Dike <jdike@addtoit.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH 7/8] UML - add virt_to_pte
Date: Sat, 17 Nov 2007 13:49:54 -0500 [thread overview]
Message-ID: <20071117184954.GB8206@c2.user-mode-linux.org> (raw)
In-Reply-To: <473EC75F.5020208@tiscali.nl>
On Sat, Nov 17, 2007 at 11:50:07AM +0100, Roel Kluin wrote:
> > + if (!pte_present(*pte))
> > + pte = NULL;
>
> shouldn't you check again for (pte == NULL)?
No, because if the page isn't mapped, handle_page_fault would have
returned non-zero, and we would have already returned.
This is leaving aside issues of whether the page could have been
unmapped by another CPU (which isn't an issue right now, and for which
I have a patch to fix anyway).
Jeff
--
Work email - jdike at linux dot intel dot com
prev parent reply other threads:[~2007-11-17 18:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 21:42 Jeff Dike
2007-11-17 10:50 ` Roel Kluin
2007-11-17 18:49 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071117184954.GB8206@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=12o3l@tiscali.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome