mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bunk@kernel.org
Cc: david-b@pacbell.net, randy.dunlap@oracle.com,
	toralf.foerster@gmx.de, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings':
Date: Mon, 19 Nov 2007 21:26:39 -0800 (PST)	[thread overview]
Message-ID: <20071119.212639.217993660.davem@davemloft.net> (raw)
In-Reply-To: <20071108033010.GF26163@stusta.de>

From: Adrian Bunk <bunk@kernel.org>
Date: Thu, 8 Nov 2007 04:30:10 +0100

> @davem:
> 
> Please look at net/ipv4/arp.c:arp_process()
> 
> Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or 
> CONFIG_NETDEV_10000=y will not be handled correctly there?
> 
> And the best solution is to nuke all #ifdef's in this function and make 
> the code unconditionally available?

I think removing those specific ifdefs in arp_process()
is the best option, yes.

  parent reply	other threads:[~2007-11-20  5:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-01 19:24 Toralf Förster
2007-11-01 21:11 ` Randy Dunlap
2007-11-01 23:32   ` David Brownell
2007-11-01 23:44     ` Adrian Bunk
2007-11-02 18:45       ` David Brownell
2007-11-02 18:57         ` Adrian Bunk
2007-11-02 19:30           ` David Brownell
2007-11-02 19:55             ` Adrian Bunk
2007-11-07 22:34               ` David Brownell
2007-11-07 22:52                 ` Adrian Bunk
2007-11-08  2:53                   ` David Brownell
2007-11-08  3:23                     ` Adrian Bunk
2007-11-08  3:30                   ` Adrian Bunk
2007-11-08 16:08                     ` Randy Dunlap
2007-11-20  5:26                     ` David Miller [this message]
2007-11-25 16:30                       ` [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess Adrian Bunk
2007-11-26 15:19                         ` Herbert Xu
2007-11-26 20:25                           ` Adrian Bunk
2007-11-02 20:05         ` build #337 failed for 2.6.24-rc1-gb1d08ac In function `usbnet_set_settings': Adrian Bunk
2007-11-07  8:20     ` David Miller
2007-11-07 22:15       ` David Brownell
2007-11-01 22:25 ` [2.6 patch] let USB_USBNET always select MII Adrian Bunk
2007-11-01 23:52   ` David Brownell
2007-11-02 15:46     ` [2.6 patch] usbnet.c: check for the right MII variable Adrian Bunk
2007-11-07 22:31       ` David Brownell
2007-11-07  8:10   ` [2.6 patch] let USB_USBNET always select MII David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071119.212639.217993660.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bunk@kernel.org \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=toralf.foerster@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome