From: Josh Boyer <jwboyer@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 8250_gsc: Coding style
Date: Mon, 19 Nov 2007 10:58:48 -0600 [thread overview]
Message-ID: <20071119105848.51a20901@weaponx> (raw)
In-Reply-To: <20071119150751.60c2df48@the-village.bc.nu>
On Mon, 19 Nov 2007 15:07:51 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
You forgot the Signed-off-by line.
josh
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/serial/8250_gsc.c linux-2.6.24-rc2-mm1/drivers/serial/8250_gsc.c
> --- linux.vanilla-2.6.24-rc2-mm1/drivers/serial/8250_gsc.c 2007-11-16 17:20:48.000000000 +0000
> +++ linux-2.6.24-rc2-mm1/drivers/serial/8250_gsc.c 2007-11-16 18:35:39.000000000 +0000
> @@ -25,8 +25,7 @@
>
> #include "8250.h"
>
> -static int __init
> -serial_init_chip(struct parisc_device *dev)
> +static int __init serial_init_chip(struct parisc_device *dev)
> {
> struct uart_port port;
> unsigned long address;
> @@ -38,18 +37,17 @@
> * what we have here is a missing parent device, so tell
> * the user what they're missing.
> */
> - if (parisc_parent(dev)->id.hw_type != HPHW_IOA) {
> - printk(KERN_INFO "Serial: device 0x%lx not configured.\n"
> + if (parisc_parent(dev)->id.hw_type != HPHW_IOA)
> + printk(KERN_INFO
> + "Serial: device 0x%lx not configured.\n"
> "Enable support for Wax, Lasi, Asp or Dino.\n",
> dev->hpa.start);
> - }
> return -ENODEV;
> }
>
> address = dev->hpa.start;
> - if (dev->id.sversion != 0x8d) {
> + if (dev->id.sversion != 0x8d)
> address += 0x800;
> - }
>
> memset(&port, 0, sizeof(port));
> port.iotype = UPIO_MEM;
> @@ -63,11 +61,12 @@
>
> err = serial8250_register_port(&port);
> if (err < 0) {
> - printk(KERN_WARNING "serial8250_register_port returned error %d\n", err);
> + printk(KERN_WARNING
> + "serial8250_register_port returned error %d\n", err);
> iounmap(port.membase);
> return err;
> }
> -
> +
> return 0;
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2007-11-19 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 15:07 Alan Cox
2007-11-19 16:58 ` Josh Boyer [this message]
2007-11-19 17:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071119105848.51a20901@weaponx \
--to=jwboyer@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®