From: Ingo Molnar <mingo@elte.hu>
To: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Cc: dmitry.adamushko@gmail.com, a.p.zijlstra@chello.nl,
dhaval@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
efault@gmx.de, skumar@linux.vnet.ibm.com,
Balbir Singh <balbir@in.ibm.com>
Subject: Re: [PATCH 2/2] sched: Improve fairness of cpu allocation for task groups
Date: Mon, 19 Nov 2007 14:12:01 +0100 [thread overview]
Message-ID: <20071119131201.GB31491@elte.hu> (raw)
In-Reply-To: <20071119123051.GC28777@linux.vnet.ibm.com>
* Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> wrote:
> The current load balancing scheme isn't good for group fairness.
> ---
> include/linux/sched.h | 4
> kernel/sched.c | 292 +++++++++++++++++++++++++++++++++++++++++++++-----
> kernel/sched_fair.c | 95 ++++++++++------
> kernel/sched_rt.c | 2
> kernel/sysctl.c | 16 ++
> 5 files changed, 348 insertions(+), 61 deletions(-)
i'm leaning towards making this v2.6.25 material, as it affects the
non-group-scheduling bits too and is rather large. When i tested it,
group scheduling worked pretty well - at least for CPU bound tasks - and
on SMP too. Could we live with what we have for now and defer this patch
to v2.6.25? If not, could you split up this patch in a way to defer all
the FAIR_GROUP_SCHED relevant changes to a separate patch which will not
affect the !FAIR_GROUP_SCHED case at all? That will make the case much
clearer.
Ingo
next prev parent reply other threads:[~2007-11-19 13:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 12:27 [PATCH 0/2] sched: Group scheduler related patches Srivatsa Vaddagiri
2007-11-19 12:28 ` [PATCH 1/2] sched: Minor cleanups Srivatsa Vaddagiri
2007-11-19 13:08 ` Ingo Molnar
2007-11-19 15:01 ` Srivatsa Vaddagiri
2007-11-19 12:30 ` [PATCH 2/2] sched: Improve fairness of cpu allocation for task groups Srivatsa Vaddagiri
2007-11-19 13:12 ` Ingo Molnar [this message]
2007-11-19 15:03 ` Srivatsa Vaddagiri
2007-11-19 15:22 ` Ingo Molnar
2007-11-19 16:06 ` Srivatsa Vaddagiri
2007-11-19 19:00 ` Ingo Molnar
2007-11-26 5:00 ` [PATCH 0/4] sched: group scheduler related patches (V3) Srivatsa Vaddagiri
2007-11-26 5:02 ` [PATCH 1/4] sched: code cleanup Srivatsa Vaddagiri
2007-11-26 5:03 ` [PATCH 2/4] sched: minor fixes for group scheduler Srivatsa Vaddagiri
2007-11-26 5:05 ` [Patch 3/4 v1] sched: change how cpu load is calculated Srivatsa Vaddagiri
2007-11-26 5:06 ` [Patch 3/4 v2] " Srivatsa Vaddagiri
2007-11-26 5:09 ` [Patch 4/4] sched: Improve fairness of cpu bandwidth allocation for task groups Srivatsa Vaddagiri
2007-11-26 20:28 ` Ingo Molnar
2007-11-27 5:06 ` [Patch 0/5] sched: group scheduler related patches (V4) Srivatsa Vaddagiri
2007-11-27 5:08 ` [Patch 1/5] sched: code cleanup Srivatsa Vaddagiri
2007-11-27 5:09 ` [Patch 2/5] sched: minor fixes for group scheduler Srivatsa Vaddagiri
2007-11-27 5:11 ` [Patch 3/5 v1] sched: change how cpu load is calculated Srivatsa Vaddagiri
2007-11-27 5:12 ` [Patch 3/5 v2] " Srivatsa Vaddagiri
2007-11-27 5:21 ` [Patch 4/5] sched: introduce a mutex and corresponding API to serialize access to doms_cur[] array Srivatsa Vaddagiri
2007-11-27 5:27 ` [Patch 5/5] sched: Improve fairness of cpu bandwidth allocation for task groups Srivatsa Vaddagiri
2007-11-27 11:09 ` [Patch 0/5] sched: group scheduler related patches (V4) Ingo Molnar
2007-11-27 11:42 ` Srivatsa Vaddagiri
2007-11-27 12:53 ` Ingo Molnar
2007-11-27 14:32 ` Srivatsa Vaddagiri
2007-11-26 20:29 ` [Patch 4/4] sched: Improve fairness of cpu bandwidth allocation for task groups Ingo Molnar
2007-11-19 18:21 [PATCH 0/2] sched: group scheduler related patches (V2) Srivatsa Vaddagiri
2007-11-19 18:31 ` [PATCH 2/2] sched: Improve fairness of cpu allocation for task groups Srivatsa Vaddagiri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071119131201.GB31491@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=balbir@in.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=dmitry.adamushko@gmail.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=skumar@linux.vnet.ibm.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®