From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 21285: Report baud rate back via termios
Date: Mon, 19 Nov 2007 15:41:37 +0000 [thread overview]
Message-ID: <20071119154137.GA30129@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20071119151222.6cfa9c4c@the-village.bc.nu>
On Mon, Nov 19, 2007 at 03:12:22PM +0000, Alan Cox wrote:
> Currently reports back the requested rate not the result of the divides
> but thats an easy fix for someone with h/w
>
> Signed-off-by: Alan Cox <alan@redhat.com>
Ack for first hunk. When can this be merged? I assume it has to wait
for tty_encode_baud_rate() to appear in mainline?
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c linux-2.6.24-rc2-mm1/drivers/serial/21285.c
> --- linux.vanilla-2.6.24-rc2-mm1/drivers/serial/21285.c 2007-11-16 17:20:48.000000000 +0000
> +++ linux-2.6.24-rc2-mm1/drivers/serial/21285.c 2007-11-16 18:35:29.000000000 +0000
> @@ -277,6 +279,8 @@
> if (termios->c_iflag & INPCK)
> port->read_status_mask |= RXSTAT_FRAME | RXSTAT_PARITY;
>
> + tty_encode_baud_rate(tty, baud, baud);
> +
> /*
> * Which character status flags should we ignore?
> */
> @@ -301,6 +305,7 @@
> *CSR_UARTCON = 1;
>
> spin_unlock_irqrestore(&port->lock, flags);
> +
> }
>
> static const char *serial21285_type(struct uart_port *port)
This hunk isn't required.
Note also that no one reads linux-arm@vger.kernel.org.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2007-11-19 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 15:12 Alan Cox
2007-11-19 15:41 ` Russell King [this message]
2007-11-19 15:50 ` Alan Cox
2007-11-19 15:55 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071119154137.GA30129@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®