From: Pete Zaitcev <zaitcev@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
zaitcev@redhat.com
Subject: Re: [PATCH] mct232: speed, new termios and compliance cleanups
Date: Tue, 20 Nov 2007 11:04:13 -0800 [thread overview]
Message-ID: <20071120110413.5f84e092.zaitcev@redhat.com> (raw)
In-Reply-To: <20071119152211.4be48986@the-village.bc.nu>
On Mon, 19 Nov 2007 15:22:11 +0000, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
This looks good, but have a couple of comments. Maybe I can fix it up.
> * we do not know how to support. We ignore them for the moment.
> * XXX Rate-limit the error message, it's user triggerable.
This XXX item is fixed by this patch, so should be removed.
> + /* FIXME: Can we use any divider - should we do
> + divider = 115200/value;
> + real baud = 115200/divider */
> switch (value) {
> case 300: break;
I do not understand this FIXME comment. What is wrong with current
code? The result of the function is given to the device's sequencer.
Do you want to get rid of the switch? Please unconfuse me.
-- Pete
next prev parent reply other threads:[~2007-11-20 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 15:22 Alan Cox
2007-11-20 19:04 ` Pete Zaitcev [this message]
2007-11-20 22:07 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120110413.5f84e092.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome