From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
"yakui.zhao" <yakui.zhao@intel.com>,
Rene Herman <rene.herman@keyaccess.nl>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] PNP cleanups - Make use of pnp_{port,mem,irq,dma}_{start,end,flags} macros wherever possible
Date: Tue, 20 Nov 2007 12:32:13 +0000 [thread overview]
Message-ID: <20071120123213.0744adc3@the-village.bc.nu> (raw)
In-Reply-To: <1195552273.23700.164.camel@queen.suse.de>
> #define pnp_irq(dev,bar) ((dev)->res.irq_resource[(bar)].start)
> +#define pnp_irq_start(dev,bar) ((dev)->res.irq_resource[(bar)].start)
> +#define pnp_irq_end(dev,bar) ((dev)->res.irq_resource[(bar)].end)
NAK as discussed earlier.
> #define pnp_irq_flags(dev,bar) ((dev)->res.irq_resource[(bar)].flags)
> #define pnp_irq_valid(dev,bar) \
> ((pnp_irq_flags((dev),(bar)) & (IORESOURCE_IRQ | IORESOURCE_UNSET)) \
> == IORESOURCE_IRQ)
>
> #define pnp_dma(dev,bar) ((dev)->res.dma_resource[(bar)].start)
> +#define pnp_dma_start(dev,bar) ((dev)->res.dma_resource[(bar)].start)
> +#define pnp_dma_end(dev,bar) ((dev)->res.dma_resource[(bar)].end)
Ditto DMA is not range based.
prev parent reply other threads:[~2007-11-20 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 9:51 Thomas Renninger
2007-11-20 10:16 ` Rene Herman
2007-11-20 12:32 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120123213.0744adc3@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
--cc=shaohua.li@intel.com \
--cc=trenn@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®