From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
"Li, Shaohua" <shaohua.li@intel.com>,
"yakui.zhao" <yakui.zhao@intel.com>,
Rene Herman <rene.herman@keyaccess.nl>
Subject: Re: [PATCH 3/3] PNP cleanups - Version 2 - Pass struct pnp_dev to pnp_clean_resource_table for cleanup reasons
Date: Tue, 20 Nov 2007 18:00:07 +0000 [thread overview]
Message-ID: <20071120180007.1ebe11a2@the-village.bc.nu> (raw)
In-Reply-To: <1195581124.23700.262.camel@queen.suse.de>
On Tue, 20 Nov 2007 18:52:04 +0100
Thomas Renninger <trenn@suse.de> wrote:
> Pass struct pnp_dev to pnp_clean_resource_table for cleanup reasons
Again I don't see the point of this change. A routine for cleaning up
resource tables expects logically to be passed a resource table to clean
up not some device it may be attached to.
Perhaps if you could explain where you are trying to end up, it would
help understand what you are trying to do.
I don't see why pnp_dma() and pnp_irq() should change either. It just
causes noise and breaks driver code. I don't see where it needs to change
to make internal pnp changes work ?
Alan
next prev parent reply other threads:[~2007-11-20 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 17:52 Thomas Renninger
2007-11-20 18:00 ` Alan Cox [this message]
2007-11-20 19:36 ` Rene Herman
2007-11-20 22:18 ` Alan Cox
2007-11-21 8:37 ` Rene Herman
2007-11-21 9:43 ` Thomas Renninger
2007-11-21 18:13 ` Alan Cox
2007-11-21 23:05 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120180007.1ebe11a2@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rene.herman@keyaccess.nl \
--cc=shaohua.li@intel.com \
--cc=trenn@suse.de \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®