From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: nico@cam.org
Cc: Andre Haupt <andre@bitwigglers.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Andre Haupt <andre@bitwigglers.org>
Subject: Re: [PATCH] sdio_uart: fix sign of paramter status in sdio_uart_receive_chars()
Date: Sat, 24 Nov 2007 15:36:50 +0100 [thread overview]
Message-ID: <20071124153650.27a572a6@poseidon.drzeus.cx> (raw)
In-Reply-To: <11956448251191-git-send-email-andre@bitwigglers.org>
On Wed, 21 Nov 2007 12:33:45 +0100
Andre Haupt <andre@bitwigglers.org> wrote:
> I think, the status paramter should be unsigned. Is this correct?
> This also fixes a sparse warning about different signedness.
> Only compile tested, because i do not have the hardware.
>
> From: Andre Haupt <andre@bitwigglers.org>
> Signed-off-by: Andre Haupt <andre@bitwigglers.org>
Nicolas, does this seem correct to you? I'm not familiar with the serial stuff.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next prev parent reply other threads:[~2007-11-24 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 11:33 Andre Haupt
2007-11-24 14:36 ` Pierre Ossman [this message]
2007-11-24 15:35 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071124153650.27a572a6@poseidon.drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=andre@bitwigglers.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®