From: Jan Kara <jack@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Morten Welinder <mwelinder@gmail.com>,
rlove@rlove.org
Subject: [PATCH] Send IN_ATTRIB events when link count changes
Date: Mon, 26 Nov 2007 17:27:58 +0100 [thread overview]
Message-ID: <20071126162758.GA856@duck.suse.cz> (raw)
In-Reply-To: <118833cc0711260806x69fc2bb6n572f1e1253a201ef@mail.gmail.com>
Hi Andrew,
would you pick up this patch for testing in -mm? Thanks.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
---
Send inotify events to the inode itself when its link count has changed.
Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: Morten Welinder <mwelinder@gmail.com>
diff --git a/fs/namei.c b/fs/namei.c
index 3b993db..9a91130 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2188,6 +2188,7 @@ int vfs_unlink(struct inode *dir, struct
/* We don't d_delete() NFS sillyrenamed files--they still exist. */
if (!error && !(dentry->d_flags & DCACHE_NFSFS_RENAMED)) {
+ fsnotify_link_count(dentry->d_inode);
d_delete(dentry);
}
@@ -2360,7 +2361,7 @@ int vfs_link(struct dentry *old_dentry,
error = dir->i_op->link(old_dentry, dir, new_dentry);
mutex_unlock(&old_dentry->d_inode->i_mutex);
if (!error)
- fsnotify_create(dir, new_dentry);
+ fsnotify_link(dir, new_dentry);
return error;
}
diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h
index 2bd31fa..b21b818 100644
--- a/include/linux/fsnotify.h
+++ b/include/linux/fsnotify.h
@@ -92,6 +92,14 @@ static inline void fsnotify_inoderemove(
}
/*
+ * fsnotify_link_count - inode's link count changed
+ */
+static inline void fsnotify_link_count(struct inode *inode)
+{
+ inotify_inode_queue_event(inode, IN_ATTRIB, 0, NULL, NULL);
+}
+
+/*
* fsnotify_create - 'name' was linked in
*/
static inline void fsnotify_create(struct inode *inode, struct dentry *dentry)
@@ -103,6 +111,18 @@ static inline void fsnotify_create(struc
}
/*
+ * fsnotify_link - new hardlink in 'inode' directory
+ */
+static inline void fsnotify_link(struct inode *inode, struct dentry *new_dentry)
+{
+ inode_dir_notify(inode, DN_CREATE);
+ inotify_inode_queue_event(inode, IN_CREATE, 0, new_dentry->d_name.name,
+ new_dentry->d_inode);
+ fsnotify_link_count(new_dentry->d_inode);
+ audit_inode_child(new_dentry->d_name.name, new_dentry, inode);
+}
+
+/*
* fsnotify_mkdir - directory 'name' was created
*/
static inline void fsnotify_mkdir(struct inode *inode, struct dentry *dentry)
next prev parent reply other threads:[~2007-11-26 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 3:11 Inotify fails to send IN_ATTRIB events Morten Welinder
2007-11-22 15:34 ` Jan Kara
2007-11-23 1:49 ` Morten Welinder
2007-11-23 14:18 ` Morten Welinder
2007-11-23 19:54 ` Morten Welinder
2007-11-26 16:00 ` Jan Kara
[not found] ` <118833cc0711260806x69fc2bb6n572f1e1253a201ef@mail.gmail.com>
2007-11-26 16:27 ` Jan Kara [this message]
2007-11-27 20:46 ` [PATCH] Send IN_ATTRIB events when link count changes Andrew Morton
2007-11-28 12:53 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126162758.GA856@duck.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mwelinder@gmail.com \
--cc=rlove@rlove.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®