From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1757705AbXK1Hoo@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757705AbXK1Hoo (ORCPT <rfc822;w@1wt.eu>);
	Wed, 28 Nov 2007 02:44:44 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750961AbXK1Hod
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 28 Nov 2007 02:44:33 -0500
Received: from pentafluge.infradead.org ([213.146.154.40]:36937 "EHLO
	pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750813AbXK1Hoc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 28 Nov 2007 02:44:32 -0500
Date: Wed, 28 Nov 2007 07:44:26 +0000
From: Christoph Hellwig <hch@infradead.org>
To: "Love, Robert W" <robert.w.love@intel.com>
Cc: linux-scsi@vger.kernel.org,
       "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
       devel@open-fcoe.org, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org, Rob Love <robert.w.love@linux.intel.com>,
       "Leech, Christopher" <christopher.leech@intel.com>,
       "Zou, Yi" <yi.zou@intel.com>, "Dev, Vasu" <vasu.dev@intel.com>,
       james.bottomley@hansenpartnership.com, davem@davemloft.net,
       jeff@garzik.org, "Kok, Auke-jan H" <auke-jan.h.kok@intel.com>,
       "Ronciak, John" <john.ronciak@intel.com>,
       "Van De Ven, Arjan" <arjan.van.de.ven@intel.com>,
       Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [ANNOUNCE] Open-FCoE - Fibre Channel over Ethernet Project
Message-ID: <20071128074426.GA30468@infradead.org>
References: <10A7D0016239E24092DEF05CCC582E43028A636B@fmsmsx411.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <10A7D0016239E24092DEF05CCC582E43028A636B@fmsmsx411.amr.corp.intel.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by pentafluge.infradead.org
	See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

I just did a very quick glance over the tree.  Some extremly highlevel
comments to start with before actually starting the source review:


 - why do you need your own libcrc?  lib/crc32.c has a crc32_le
 - libsa should go.  Much of it is just wrappers of kernel functions
   that should be used directly.  Other like that hash, even or state
   helpers might either be opencoded in the caller or made completely
   generic in lib/.  Probably the former but we'll have to see.