mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Mark Lord <lkml@rtr.ca>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] base/class.c: prevent ooops due to insert/remove race
Date: Wed, 28 Nov 2007 20:33:07 -0800	[thread overview]
Message-ID: <20071129043307.GA4766@suse.de> (raw)
In-Reply-To: <474E3964.7040200@rtr.ca>

On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote:
> While doing insert/remove (quickly) tests on USB, I managed to trigger
> an Oops on 2.6.23.1 on the call to strlen() in make_class_name().
>
> This patch prevents this oops.
>
> There is still the larger problem of the overall race
> that caused this in the first place, but much of the rest
> of the code in class.c appears to also do NULL checks to
> avoid Oops'ing, so this continues the tradition.
>
> Signed-off-by:  Mark Lord <mlord@pobox.com>

As this is a bandage over the real problem, I'd prefer to not apply this
one right now until we find the root cause.

thanks,

greg k-h

  reply	other threads:[~2007-11-29  4:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  4:00 Mark Lord
2007-11-29  4:33 ` Greg KH [this message]
2007-11-29 15:41   ` Mark Lord
2007-11-29 16:27     ` Greg KH
2007-11-29 17:45       ` Mark Lord
2007-11-29 17:48         ` Mark Lord
2007-11-29 17:50           ` Mark Lord
2007-11-29 18:09             ` [PATCH] base/class.c: prevent ooops due to insert/remove race (v3) Mark Lord
2007-11-29 18:12               ` Mark Lord
2007-11-29 19:20                 ` [linux-usb-devel] " Alan Stern
2007-11-29 20:01                   ` Mark Lord
2007-11-29 20:12                     ` Greg KH
     [not found]                       ` <474F1DB3.4030900@rtr.ca>
2007-11-29 20:25                         ` Mark Lord
2007-11-29 20:32                           ` Greg KH
2007-11-29 20:46                             ` Mark Lord
2007-11-29 21:17                               ` Greg KH
2007-11-29 22:07                               ` Alan Stern
2007-11-29 22:11                                 ` Greg KH
2007-11-29 22:28                                 ` Mark Lord
2007-11-29 22:43                                   ` Alan Stern
2007-11-29 23:09                                 ` Linus Torvalds
2007-11-30  2:58                                   ` Alan Stern
2007-11-29 20:13                     ` Alan Stern
2007-11-29 20:17                       ` Mark Lord
2007-11-29 20:20                       ` Mark Lord
2007-11-29 21:59                         ` Alan Stern
2007-11-29 15:59   ` [PATCH] base/class.c: prevent ooops due to insert/remove race (v2) Mark Lord

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071129043307.GA4766@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml@rtr.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome