From: Oleg Nesterov <oleg@tv-sign.ru>
To: Robin Holt <holt@sgi.com>
Cc: Roland McGrath <roland@redhat.com>,
Kawai@americas.sgi.com, Hidehiro <hidehiro.kawai.ez@hitachi.com>,
Davide Libenzi <davidel@xmailserver.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>, Bron Nelson <bron@sgi.com>,
Stephen Champion <schamp@sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: Can we make application core dumps interruptible?
Date: Thu, 29 Nov 2007 15:01:19 +0300 [thread overview]
Message-ID: <20071129120119.GA4385@tv-sign.ru> (raw)
In-Reply-To: <20071128123823.GB919@lnx-holt.americas.sgi.com>
On 11/28, Robin Holt wrote:
>
> We have a customer machine with 4096 cpus. When some user applications
> crash, it begins dumping core and can tie up the filesystem and
> processors for a considerable period of time. Often, they contact the
> user and the user says the core dump files will not be useful and they
> reboot the machine. They have already reduced the default core dump size
> to not dump anything and taken all reasonable steps to limiting core dumps
> while still allowing them to be useful for those users that need them.
> They would like to not need to reboot.
>
> They hoped for a couple changes, one of which is a way for a SIGTERM,
> SIGKILL, or something along that line interrupting the core dump process.
> Is this the correct direction to take? Are there any better ideas for
> handling this?
Well, I don't know what would be the right soultion, but perhaps we can do
something like the patch below. Allows to abort the coredump with kill -9.
Oleg.
--- fs/binfmt_elf.c~ 2007-10-25 16:22:10.000000000 +0400
+++ fs/binfmt_elf.c 2007-11-29 14:47:43.000000000 +0300
@@ -1178,6 +1178,9 @@ out:
*/
static int dump_write(struct file *file, const void *addr, int nr)
{
+ if (sigismember(¤t->signal->shared_pending.signal, SIGKILL))
+ return 0;
+
return file->f_op->write(file, addr, nr, &file->f_pos) == nr;
}
prev parent reply other threads:[~2007-11-29 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 12:38 Robin Holt
2007-11-28 12:55 ` Alan Cox
2007-11-29 12:01 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071129120119.GA4385@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=Kawai@americas.sgi.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bron@sgi.com \
--cc=davidel@xmailserver.org \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=schamp@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®